fix(data): fix for data.labels=false

Make sure to not execute .redrawText() when data.labels set to 'false'. Ref #1444
naver · Jun 15, 2020 · b7a0972 · b7a0972
1 parent 8a8d1d1
commit b7a0972
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/ChartInternal/internals/redraw.ts b/src/ChartInternal/internals/redraw.ts
@@ -190,7 +190,7 @@ export default {
 		}
 
 		if (!$$.hasArcType() || hasRadar) {
-			notEmpty(config.data_labels) &&
+			notEmpty(config.data_labels) && config.data_labels !== false &&
 				list.push($$.redrawText(xForText, yForText, flow, isTransition));
 		}
 

diff --git a/test/internals/data-spec.ts b/test/internals/data-spec.ts
@@ -628,6 +628,15 @@ describe("DATA", () => {
 				expect(texts.empty()).to.be.false;
 				expect(texts.size() > 0).to.be.true;
 			});
+
+			it("set option data.labels=false", () => {
+				args.data.labels = false;
+			});
+
+			it("shouldn't be thrown error", () => {
+				// reaching this test, means test was passed.
+				expect(true).to.be.true;
+			});
 		});
 
 		describe("on area chart", () => {