New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPFabric integration #137

Merged

jdrew82 merged 23 commits into develop from u/snaselj-130-ipfabric

Sep 1, 2023

Contributor

snaselj commented Jun 9, 2023 •

edited by alhogan

Loading

Closes #130

Adds IPFabric integration from nautobot-plugin-ssot-ipfabric.

TODO

Test integration.
Fix configuration.
Bump dependency to the IPFabric integraton version of nautobot-chatops App.

snaselj added 7 commits

June 9, 2023 09:46


          chore: Add IPFabric files

82328bf


          chore: Dependencies

a8ea1c4


          fix: Imports

049f856


          fix: Configs

ace9354


          fix: Signals

86ba3b5


          fix: Test

e387730


          fix: Duplicate code

747cc0e

snaselj commented

View reviewed changes

development/nautobot_config.py Outdated Show resolved Hide resolved

snaselj commented

View reviewed changes

development/nautobot_config.py Outdated Show resolved Hide resolved

snaselj commented

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

snaselj commented

View reviewed changes

nautobot_ssot/integrations/ipfabric/diffsync/adapter_ipfabric.py Outdated Show resolved Hide resolved

snaselj commented

View reviewed changes

nautobot_ssot/integrations/ipfabric/diffsync/diffsync_models.py Outdated Show resolved Hide resolved

snaselj commented

View reviewed changes

nautobot_ssot/integrations/ipfabric/jobs.py Outdated Show resolved Hide resolved

Base automatically changed from u/snaselj-115-integrations to develop

June 12, 2023 15:04

snaselj mentioned this pull request

Migrate IP Fabric SSoT Plugin to This Repo #130

Closed

chadell mentioned this pull request

Consider SSoT Packaging #83

Closed


          Merge remote-tracking branch 'origin/develop' into u/snaselj-130-ipfa…

de67135

…bric

Contributor Author

snaselj commented Aug 8, 2023

Merged with the latest develop to resolve conflicts

pke11y and others added 6 commits

August 8, 2023 14:49


          Porting ssot-ipfabric v2.0.2

4b83cd6


          Linting updates

84b3da4


          Merge remote-tracking branch 'origin/u/snaselj-130-ipfabric' into pk-…

3efcee8

…v2.0.2-port


          Merge pull request #155 from nautobot/pk-v2.0.2-port

5d628d8

Port IP Fabric release v2.0.2 into integration PR


          fix: Create constants

b0c57af


          fix: Chatops 2.0 dependency

065e7ce

snaselj mentioned this pull request

fix: Use App without extras installed nautobot/nautobot-app-chatops#233

Merged


          fix: Use ChatOps with ipfabric extra

28bdf6e

bryanculver reviewed

View reviewed changes

pyproject.toml Outdated

    
            @@ -81,7 +81,7 @@ mkdocstrings-python = "0.8.3"
          
              requests-mock = "^1.10.0"

              parameterized = "^0.8.1"

              myst-parser = "^0.15.2"

              nautobot-chatops = "^2.0.0"

              nautobot-chatops = { version = "^2.0.2", extras = ["ipfabric"] }

Member

bryanculver Aug 9, 2023

2.0.2 doesn't exist yet. 2.0.1 was just released. Please update the lockfile after this change.

Contributor Author

snaselj Aug 21, 2023

Fixed

alhogan and others added 2 commits

August 9, 2023 12:19


          Merge #131 from old repo

f58117b


          Locally passing

123804a

Contributor Author

snaselj commented Aug 17, 2023 •

edited

Loading

Blocked by #157 due to the following dependency: https://github.com/nautobot/nautobot-plugin-ssot/pull/137/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R84

snaselj added 5 commits

August 21, 2023 07:56


          Merge pull request #156 from nautobot/ahogan-device-role

d9c5335

Merge nautobot-plugin-ssot-ipfabric/pull/131


          chore: Remove Nautobot ChatOps dependency

573ded9


          fix: pylint

4ee2f97


          fix: Black

05afef3


          fix: Use 3.8 for CI

c5fda42

snaselj mentioned this pull request

Finalize Integrations #152

Merged

4 tasks

snaselj marked this pull request as ready for review

August 23, 2023 10:30

snaselj requested a review from a team as a code owner

August 23, 2023 10:30

chadell reviewed

View reviewed changes

Contributor

chadell left a comment

I think that the integration makes sense. I would only ask @alhogan or @pke11y to test it and verify that it works as expected

Contributor

alhogan commented Aug 23, 2023

I will carve out some time to test it this week.

Contributor

alhogan commented Aug 30, 2023

I ran a few tests and saw some discrepancies in the number of objects been created/updated/deleted. I will dig a little deeper into the results to see what is causing this and provide an update shortly.

Kircheneer added the status: action required label


          fix null value for interface description

735b682

Contributor

alhogan commented Sep 1, 2023

Found the source of the discrepancies. Null interface descriptions were throwing false-positives in the diff. Fix has been implemented and we should be good to go on merging this one.

jdrew82 merged commit 9006390 into develop

jdrew82 deleted the u/snaselj-130-ipfabric branch

September 1, 2023 13:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: action required