Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to python 3.8 minimum #157

Closed
wants to merge 2 commits into from
Closed

Move to python 3.8 minimum #157

wants to merge 2 commits into from

Conversation

cmsirbu
Copy link
Contributor

@cmsirbu cmsirbu commented Aug 16, 2023

Drops support for Python 3.7 and updates poetry.lock.

FIXES:

nautobot_ssot/filters.py:32:0: R0022: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.readthedocs.io/en/latest/whatsnew/2/2.14/summary.html#removed-checkers. (useless-option-value)
INFO     -  DeprecationWarning: invalid escape sequence '\/'
              File
            "/home/vagrant/.cache/pypoetry/virtualenvs/nautobot-ssot-SCbO3rSM-py3.10/lib/python3.10/site-packages/griffe/agents/visitor.py",
            line 179, in get_module
                top_node = compile(self.code, mode="exec", filename=str(self.filepath), flags=ast.PyCF_ONLY_AST,
            optimize=1)
              File "nautobot_ssot/integrations/aci/diffsync/utils.py", line 36, in
                pattern = "tn-(.+?)\/"  # noqa: W605  # pylint: disable=anomalous-backslash-in-string
INFO     -  DeprecationWarning: invalid escape sequence '\-'
              File
            "/home/vagrant/.cache/pypoetry/virtualenvs/nautobot-ssot-SCbO3rSM-py3.10/lib/python3.10/site-packages/griffe/agents/visitor.py",
            line 179, in get_module
                top_node = compile(self.code, mode="exec", filename=str(self.filepath), flags=ast.PyCF_ONLY_AST,
            optimize=1)
              File "nautobot_ssot/integrations/aci/diffsync/utils.py", line 42, in
                pattern = "ap-[A-Za-z0-9\-]+"  # noqa: W605 # pylint: disable=anomalous-backslash-in-string

TODO:

  • Fix new pylint errors due to the major version bump unconstrained by python 3.7
  • Possibly bump minimum nautobot version to 1.5.13 (which is tested by CI)

@snaselj snaselj mentioned this pull request Aug 17, 2023
3 tasks
@jdrew82
Copy link
Contributor

jdrew82 commented Sep 14, 2023

Closing as this is address by #207.

@jdrew82 jdrew82 closed this Sep 14, 2023
@jdrew82 jdrew82 deleted the u/cmsirbu-drop-py37 branch March 14, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants