-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize Integrations #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Don't forget to also add the contributor thanks in the readme for all the individual repos the integrations came from.
All comments are addressed now, could you pls. check it @cmsirbu ? |
You'll also need to add the admin integrations to
|
Added Arista CloudVision integration, could you pls. check it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the structure! let's move it forward
Co-authored-by: Christian Adell <[email protected]>
Blocked by #137 |
Added all integrations documentation, it's ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few tweaks but mostly looking good!
Thanks, PR is fixed now. |
@snaselj Looks like there's a conflict with the nautobot_config.py file. Can we get that resolved? Looks good otherwise. |
Conflicts are resolved now @jdrew82 |
still one conflict with |
Another set of conflicts resolved now @chadell |
@chadell Could you pls. check two different |
I don't see the code reference doc ( Could you point me out on what's different? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes NaN
Finish adding integrations.
Done
To-Do