[Maintenance] Update CIrcleCI redirector circleci.yml to fix artifact path #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psobolewskiPhD
added
maintenance
psobolewskiPhD
changed the title
psobolewskiPhD
changed the title
|
Hopefully this fixes it and if so I'll make PR to napari/napari where the same issue occurs. |
melissawm
approved these changes
Nov 21, 2023
|
fixed it -- the 0 is needed, see the links to the artifacts: But I think this needs to be merged to see it run on CI, so I will optimistically mark ready-to-merge and we'll see and fix as needed. |
Czaki
approved these changes
Nov 21, 2023
|
Looks like everything works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
The CircleCI redirector is not re-directing properly even when build succeeds, see:
#273 (comment)
Description
In #266 the artifact path got changed. This fixes the redirector action to use the new path.