Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform circleCI and build_docs workflows across repositories #266

Merged
merged 14 commits into from
Nov 12, 2023

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Nov 7, 2023

References and relevant issues

together with napari/napari#6417 closes #261

Description

Diff:

diff .circleci/config.yml ../napari/.circleci/config.yml                                                     1 ↵
10c10
<           path: docs
---
>           path: napari
12,13c12,13
<           name: Clone main repo into a subdirectory
<           command: git clone [email protected]:napari/napari.git napari
---
>           name: Clone docs repo into a subdirectory
>           command: git clone [email protected]:napari/docs.git docs
diff .github/workflows/build_docs.yml ../napari/.github/workflows/build_docs.yml                             1 ↵
2c2
< # https://github.com/napari/napari/blob/main/.github/workflows/build_docs.yml
---
> # https://github.com/napari/docs/blob/main/.github/workflows/build_docs.yml
6c6
<   pull_request:
---
>   push:
8c8,10
<       - main
---
>       - docs
>     tags:
>       - 'v*'
9a12
>   workflow_call:
19a23
>           repository: napari/docs
25d28
<           repository: napari/napari

@Czaki Czaki added this to the 0.5.0 milestone Nov 7, 2023
@Czaki Czaki requested a review from psobolewskiPhD November 7, 2023 09:34
@github-actions github-actions bot added the task label Nov 7, 2023
@Czaki Czaki requested a review from melissawm November 7, 2023 13:12
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- run:
name: Build docs
command: |
. venv/bin/activate
xvfb-run --auto-servernum make docs GALLERY_PATH=../napari/examples/
cd docs
xvfb-run --auto-servernum make docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as napari/napari#6417, check if we need to explicitly set GALLERY_PATH

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GALLERY_PATH should be GALLERY_PATH=../../napari/examples/ but this is default value

@psobolewskiPhD psobolewskiPhD changed the title Uniform workflow acros repositories Uniform circleCI and build_docs workflows across repositories Nov 8, 2023
@psobolewskiPhD
Copy link
Member

Same as the other PR, I'd like to keep (some) of the CircleCI comments, just to make life easier from a maintenance PoV.

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment made for both PR to add reminder about syncing the circleCI too.

Co-authored-by: Peter Sobolewski <[email protected]>
@Czaki
Copy link
Contributor Author

Czaki commented Nov 12, 2023

merge as napari/napari#6417 is merged

@Czaki Czaki merged commit 1a3192f into napari:main Nov 12, 2023
6 checks passed
@Czaki Czaki deleted the uniform_workflow branch November 12, 2023 16:40
jni pushed a commit that referenced this pull request Nov 21, 2023
… path (#278)

# References and relevant issues

The CircleCI redirector is not re-directing properly even when build
succeeds, see:
#273 (comment)

# Description

In #266 the artifact path got
changed. This fixes the redirector action to use the new path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uniform circleci workflow with main repository
3 participants