-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniform circleCI and build_docs workflows across repositories #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- run: | ||
name: Build docs | ||
command: | | ||
. venv/bin/activate | ||
xvfb-run --auto-servernum make docs GALLERY_PATH=../napari/examples/ | ||
cd docs | ||
xvfb-run --auto-servernum make docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as napari/napari#6417, check if we need to explicitly set GALLERY_PATH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GALLERY_PATH
should be GALLERY_PATH=../../napari/examples/
but this is default value
Same as the other PR, I'd like to keep (some) of the CircleCI comments, just to make life easier from a maintenance PoV. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment made for both PR to add reminder about syncing the circleCI too.
Co-authored-by: Peter Sobolewski <[email protected]>
merge as napari/napari#6417 is merged |
… path (#278) # References and relevant issues The CircleCI redirector is not re-directing properly even when build succeeds, see: #273 (comment) # Description In #266 the artifact path got changed. This fixes the redirector action to use the new path.
References and relevant issues
together with napari/napari#6417 closes #261
Description
Diff: