Add missed pinning dependencies #260
Conversation
| @@ -52,7 +52,7 @@ jobs: | |||
| name: Install python dependencies | |||
| command: | | |||
| . venv/bin/activate | |||
| python -m pip install -r requirements.txt | |||
| python -m pip install -r requirements.txt -c "napari/resources/constraints/constraints_py3.10_docs.txt" | |||
There was a problem hiding this comment.
We need to update this constraint first, though: https://github.com/napari/napari/blob/467d57b3967074370b2ad6750bdfc1af8aee67d6/resources/constraints/constraints_py3.10_docs.txt#L507
There was a problem hiding this comment.
The import failure in #259 is due to sphinx < 5
(That import requires sphinx >5.1)
#256 (comment)
There was a problem hiding this comment.
Oh, nvm, I see. The constraints pins back sphinx_tags to 0.2.1
https://github.com/napari/napari/blob/467d57b3967074370b2ad6750bdfc1af8aee67d6/resources/constraints/constraints_py3.10_docs.txt#L539
There was a problem hiding this comment.
Yes. constraints pins sphinx-tags and napari-sphinx-theme.
And until update constraints files there will be no problem.
Of course, relax sphinx in requirements.txt is required for constraints compilation provide newer sphinx and napari-sphinx-theme
Czaki
force-pushed
the
fix_dependecies_pin
branch
from
908c0d9 to
d08ca5a
Compare
|
@Czaki Can't suggest, but don't we need the constraint to be set in the Build phase too? Same in the build_docs, but like like 51/52 |
|
Merging to get docs to build |
Description
Closes #259
using the constraints file pins back sphinx_tags to 0.2.1 which is compatible with sphinx<5