Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to fail docs build on gallery example execution error #256

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

melissawm
Copy link
Member

References and relevant issues

Closes napari/napari#6392
Depends on #255

Description

Added a sphinx gallery option to fail the docs build on example execution failure.

Right now, this should fail on CI due to one of our example failing, but the docs build will anyway depend on the #255.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 27, 2023
@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Oct 31, 2023
@psobolewskiPhD
Copy link
Member

psobolewskiPhD commented Oct 31, 2023

Build is failing due to sphinx_tags release today, which has:
melissawm/sphinx-tags@6351df0

This import requires sphinx 5.1...
I think we can lift the pin here to <6 and in https://github.com/napari/napari-sphinx-theme

Edit: I'm going to test it...

@psobolewskiPhD
Copy link
Member

I bumped the pin in napari-sphinx-theme and in this repo to <6, and the docs built locally with the new sphinx_tags.
I'll open PRs.
So this one either needs to pin pack sphinx_tags or we go with the <6

@melissawm
Copy link
Member Author

melissawm commented Oct 31, 2023

Thanks for checking that @psobolewskiPhD - so I guess this leaves us a choice, really. Do we cut a new napari-sphinx-theme release, or do we go with the new theme infrastructure, that already supports any sphinx<6? (We can also just pin sphinx-tags for now)

@psobolewskiPhD
Copy link
Member

Yes! This seems as good a reason as any to cut over to your theme!

@melissawm
Copy link
Member Author

ok - it looks like this is "failing correctly" 😅

@psobolewskiPhD
Copy link
Member

So the fail--expected--is vortex right? And that is fixed by napari/napari#6475

@psobolewskiPhD
Copy link
Member

Going to merge main, because vortex fix has been merged. Then if everything is green this should be good to go!

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery examples failing to build should be an error
2 participants