-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to fail docs build on gallery example execution error #256
Conversation
Build is failing due to This import requires sphinx 5.1... Edit: I'm going to test it... |
I bumped the pin in napari-sphinx-theme and in this repo to |
Thanks for checking that @psobolewskiPhD - so I guess this leaves us a choice, really. Do we cut a new napari-sphinx-theme release, or do we go with the new theme infrastructure, that already supports any sphinx<6? (We can also just pin sphinx-tags for now) |
Yes! This seems as good a reason as any to cut over to your theme! |
ok - it looks like this is "failing correctly" 😅 |
So the fail--expected--is vortex right? And that is fixed by napari/napari#6475 |
Going to merge main, because vortex fix has been merged. Then if everything is green this should be good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
❤️
References and relevant issues
Closes napari/napari#6392
Depends on #255
Description
Added a sphinx gallery option to fail the docs build on example execution failure.
Right now, this should fail on CI due to one of our example failing, but the docs build will anyway depend on the #255.