Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs build is failing #259

Closed
melissawm opened this issue Oct 31, 2023 · 4 comments · Fixed by #260
Closed

Docs build is failing #259

melissawm opened this issue Oct 31, 2023 · 4 comments · Fixed by #260
Labels
bug Something isn't working

Comments

@melissawm
Copy link
Member

🐛 Bug

We're getting a

Extension error:
Could not import extension sphinx_tags (exception: cannot import name 'get_matching_files' from 'sphinx.util.matching' (/home/circleci/project/venv/lib/python3.10/site-packages/sphinx/util/matching.py))
make: *** [Makefile:30: docs-build] Error 2

See, for example, https://app.circleci.com/pipelines/github/napari/docs/365/workflows/73b5e766-7082-4c2f-9774-dffa61a364e6/jobs/355?invite=true#step-107-2326_16

I will try to take a look.
@melissawm melissawm added the bug Something isn't working label Oct 31, 2023
@psobolewskiPhD
Copy link
Member

I noticed it in the other PR:
#256 (comment)
It's due to a new sphinx_tags release 👀 That import requires sphinx >5.1

@psobolewskiPhD psobolewskiPhD mentioned this issue Oct 31, 2023
Closed
@psobolewskiPhD
Copy link
Member

It passes with sphinx 5.3 (lifted pin to <6), oddly it works even without the same change in the sphinx-theme

@Czaki
Copy link
Contributor

Czaki commented Oct 31, 2023

yes, but it should be guarded by a constraints file.

@melissawm
Copy link
Member Author

#256 (comment)

cc @jni

This was referenced Oct 31, 2023
Merged
Closed
psobolewskiPhD pushed a commit that referenced this issue Nov 1, 2023
@Czaki
Add missed pinning dependencies (#260)
9c82ab9 
# Description
Closes #259
using the constraints file pins back sphinx_tags to 0.2.1 which is
compatible with sphinx<5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@Czaki @melissawm @psobolewskiPhD