420_porting #20403
Merged
420_porting #20403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decouples the actual Excerpt name (shown in UI, and in the Excerpt itself) from the name under which it is saved in the MSC file. This way, the Excerpt name can be whatever the user wants, but still the excerpt can safely be saved in the file.
…standard" For example, when opening pre-4.2 files. This also gives us more freedom to easily change the excerpt file name generation algorithm in the future.
…n the same tick when a repeat ends 1. segmentEndTick represents either the last tick of the score (if no repeats) or the last tick of the current repeat 2. If a hairpin starts on the same tick as specified in segmentEndTick (i.e., on the 1st beat after the repeat sign), findOverlapping will find it (it doesn't belong to the repeat), causing the found hairpin to overlap with other hairpins within the repeat So, ignore hairpins that start on segmentEndTick by subtracting 1 tick, as they don't belong to that repeat
Swap figure-dash with n-dash character. Set default size to 9pt.
remove pkgconfig manual overrides for appimageupdatetool unnecessary on focal and newer distros
between the time that the original armhf/arm64 PR was made and now upstream has started building some dependencies for armhf/arm64 in their own CI and publishing releases. unfortunately we cannot use these releases since appimages (even the extraction command) do not run inside of the armhf/arm64 docker container AppImage/AppImageKit#1027 replace wget with curl (in make_appimage) due to armhf bug https://bugs.launchpad.net/ubuntu/+source/wget/+bug/2043636
avoids needing gpgme which, in order to build, requires _FILE_OFFSET_BITS=64 which causes issues with linking to system libz.so.1 /usr/bin/ld: libzsync2_standalone.a(zsclient.cpp.o): undefined reference to symbol 'gzopen64@@ZLIB_1.2.3.3' /usr/bin/ld: /lib/arm-linux-gnueabihf/libz.so.1: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status AppImageCommunity/AppImageUpdate#230
…they contain instrument name" This reverts commit aa01560.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20303
#20210
#20374
#20347
#20354
#20322
#20175
#20280
#20301
#20332
#20319
#20304
#20328
#20310
#20356
#20354
#20363
#20302
#20276
#20346
#20321
#20242
#20253
#20366