-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add patchelf ppa for ARM to fix running on non-4K pagesizes #20356
CI: add patchelf ppa for ARM to fix running on non-4K pagesizes #20356
Conversation
Also please pick this to 4.2.0 branch as well |
OK, I clicked https://github.com/theofficialgman/MuseScore/actions/runs/7123620314, then https://github.com/theofficialgman/MuseScore/suites/18829333452/artifacts/1098451649, which downloaded Seemed to launch OK now ...except that (EDIT: removed false alert about the application window not being a proper Wayland window) everything was tiny on the screen (screenshot here), for comparison, the Fedora distro package for MuseScore 4.1 looked better (screenshot here) Also, the window icon (in the upper left corner) was a weird X.org logo instead of the MuseScore logo. And this looked suspicious:
|
this is unrelated to the PR. I would suggest opening a new issue or going to the original PR where wayland support was enabled #13781 |
linuxdeploy-plugin-qt is too old on the arm setup script to use the EXTRA_PLATFORM_PLUGINS linuxdeploy/linuxdeploy-plugin-qt@76a163b I will see about bumping the version |
OK thanks (I won't file a new issue, at least not yet). BTW I verified that it was indeed a "real" wayland window (my KDE Plasma 6 fractional scaling (175 %) was not applied I think) |
@theofficialgman Do you prefer if I merge this PR (which improves the situation anyway) right now, or do you want to add the linuxdeplay-plugin-qt update to this PR as well? |
@cbjeukendrup go ahead and merge |
Sounds great, thanks! |
also drop 4K pagesize requirement as this was corrected upstream by using a newer version of patchelf musescore/MuseScore#20356
Resolves: #20342
@cbjeukendrup
Use patchelf from ppa (backported from jammy) created for fix running on non 4K pagesizes (NixOS/patchelf@0470d69).
https://launchpad.net/~theofficialgman/+archive/ubuntu/patchelf
test run here: https://github.com/theofficialgman/MuseScore/actions/runs/7123620314
Verified the isssue is fixed on an ARM64 system with 16K pagesize (Pi5 with 16K pagesize kernel).