Fix computation of Spanner start element in presence of MMRests #20346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Dec 6, 2023
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
zacjansheski
approved these changes
Dec 6, 2023
cbjeukendrup
approved these changes
Dec 6, 2023
|
@zacjansheski I've fixed another closely related issue, let me know if it all work alright! |
oktophonie
approved these changes
Dec 7, 2023
mike-spa
force-pushed
the
correctSpannerStartElementComputation
branch
from
c801943 to
610da9c
Compare
cbjeukendrup
approved these changes
Dec 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #20337
Resolves: #20340