Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packetdrill: Support MPC+DATA+checksum error #234

Open
spoorva opened this issue Oct 1, 2021 · 2 comments
Open

Packetdrill: Support MPC+DATA+checksum error #234

spoorva opened this issue Oct 1, 2021 · 2 comments
Labels
enhancement packetdrill

Comments

@spoorva
Copy link

spoorva commented Oct 1, 2021

Packetdrill throws a "bad outbound TCP options" error when an outbound packet contains mpc+datalen. The data length field shows up "unknown length" in the actual packet.
@dcaratti
Copy link
Contributor

the problem is, packetdrill does not support MPC+DATA+checksum at all. I'm working on extending the current code to support it

@dcaratti dcaratti self-assigned this Oct 20, 2021
@matttbe
Copy link
Member

matttbe commented Oct 28, 2021

I suggest to convert this as a "new feature": we need to support MPC+DATA+checksum. Please tell me if it is not OK!

@matttbe matttbe changed the title error in packetdrill when outbound packet contains mpc+datalen Packetdrill: Support MPC+DATA+checksum error Oct 28, 2021
@matttbe matttbe added enhancement and removed bug labels Oct 28, 2021
@matttbe matttbe assigned spoorva and unassigned dcaratti Jan 20, 2022
@matttbe matttbe moved this to Needs triage in MPTCP Upstream: Future Feb 22, 2023
jenkins-tessares pushed a commit that referenced this issue Jul 20, 2023
@borkmann
selftests/bpf: Add mprog API tests for BPF tcx links
c6d479b 
Add a big batch of test coverage to assert all aspects of the tcx link API:

  # ./vmtest.sh -- ./test_progs -t tc_links
  [...]
  #225     tc_links_after:OK
  #226     tc_links_append:OK
  #227     tc_links_basic:OK
  #228     tc_links_before:OK
  #229     tc_links_chain_classic:OK
  #230     tc_links_dev_cleanup:OK
  #231     tc_links_invalid:OK
  #232     tc_links_prepend:OK
  #233     tc_links_replace:OK
  #234     tc_links_revision:OK
  Summary: 10/0 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Daniel Borkmann <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Alexei Starovoitov <[email protected]>
matttbe pushed a commit that referenced this issue Aug 17, 2023
@borkmann
selftests/bpf: Add various more tcx test cases
ccd9a8b 
Add several new tcx test cases to improve test coverage. This also includes
a few new tests with ingress instead of clsact qdisc, to cover the fix from
commit dc644b5 ("tcx: Fix splat in ingress_destroy upon tcx_entry_free").

  # ./test_progs -t tc
  [...]
  #234     tc_links_after:OK
  #235     tc_links_append:OK
  #236     tc_links_basic:OK
  #237     tc_links_before:OK
  #238     tc_links_chain_classic:OK
  #239     tc_links_chain_mixed:OK
  #240     tc_links_dev_cleanup:OK
  #241     tc_links_dev_mixed:OK
  #242     tc_links_ingress:OK
  #243     tc_links_invalid:OK
  #244     tc_links_prepend:OK
  #245     tc_links_replace:OK
  #246     tc_links_revision:OK
  #247     tc_opts_after:OK
  #248     tc_opts_append:OK
  #249     tc_opts_basic:OK
  #250     tc_opts_before:OK
  #251     tc_opts_chain_classic:OK
  #252     tc_opts_chain_mixed:OK
  #253     tc_opts_delete_empty:OK
  #254     tc_opts_demixed:OK
  #255     tc_opts_detach:OK
  #256     tc_opts_detach_after:OK
  #257     tc_opts_detach_before:OK
  #258     tc_opts_dev_cleanup:OK
  #259     tc_opts_invalid:OK
  #260     tc_opts_mixed:OK
  #261     tc_opts_prepend:OK
  #262     tc_opts_replace:OK
  #263     tc_opts_revision:OK
  [...]
  Summary: 44/38 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Daniel Borkmann <[email protected]>
Link: https://lore.kernel.org/r/8699efc284b75ccdc51ddf7062fa2370330dc6c0.1692029283.git.daniel@iogearbox.net
Signed-off-by: Martin KaFai Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement packetdrill
Projects
MPTCP Upstream: Future
Status: Needs triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matttbe @dcaratti @spoorva