Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Fix transition of tooltips on vertical slider #33009

Merged
merged 7 commits into from
Jul 18, 2022
Merged

[Slider] Fix transition of tooltips on vertical slider #33009

merged 7 commits into from
Jul 18, 2022

Conversation

abhinav-22-tech
Copy link
Contributor

@abhinav-22-tech abhinav-22-tech commented Jun 3, 2022 •
edited by oliviertassinari
Loading

@mui-bot
Copy link

mui-bot commented Jun 3, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 341ffc8

@abhinav-22-tech abhinav-22-tech marked this pull request as ready for review June 3, 2022 15:06
@oliviertassinari oliviertassinari mentioned this pull request Jun 3, 2022
Merged
@oliviertassinari
Copy link
Member

@abhinav-22-tech Thank you, it feels much better ☺️. One last thing, it's not correclty vertically aligned:

Screenshot 2022-06-03 at 18 20 42

@oliviertassinari oliviertassinari mentioned this pull request Jun 3, 2022
Merged
1 task
@abhinav-22-tech abhinav-22-tech mentioned this pull request Jul 6, 2022
Closed
2 tasks
@michaldudak michaldudak linked an issue Jul 11, 2022 that may be closed by this pull request
[website] Slider Label is broken in landing page #33355
Closed
2 tasks
michaldudak
michaldudak approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! regression A bug, but worse labels Jul 15, 2022
@mnajdova mnajdova merged commit c31de22 into mui:master Jul 18, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@abhinav-22-tech
[Slider] Fix transition of tooltips on vertical slider (mui#33009)
05a5375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[website] Slider Label is broken in landing page
5 participants
@abhinav-22-tech @mui-bot @oliviertassinari @michaldudak @mnajdova