-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alert] Constrain message width and allow overflow #32747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, let's add a regression test for it. It should live here - https://github.com/mui/material-ui/tree/master/test/regressions/fixtures/Alert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @Janpot
I've definitely seen CI break on my last two PRs because of missing labels |
Reproduction: https://codesandbox.io/s/actionalerts-material-demo-forked-7fi9zq?file=/demo.tsx
Got hit by this while displaying stack traces in an
Alert
.