Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alert] Constrain message width and allow overflow #32747

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented May 12, 2022

Reproduction: https://codesandbox.io/s/actionalerts-material-demo-forked-7fi9zq?file=/demo.tsx

Got hit by this while displaying stack traces in an Alert.

@mui-bot
Copy link

mui-bot commented May 12, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 6867a57

@Janpot
Copy link
Member Author

Janpot commented May 12, 2022

Looks like the build hits this issue: #30200, #30201

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's add a regression test for it. It should live here - https://github.com/mui/material-ui/tree/master/test/regressions/fixtures/Alert

@Janpot
Copy link
Member Author

Janpot commented May 19, 2022

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Janpot

@mnajdova mnajdova merged commit 00e0dc7 into mui:master Jun 3, 2022
@Janpot Janpot deleted the alert-overflow branch June 3, 2022 13:16
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: alert This is the name of the generic UI component, not the React module! labels Jun 3, 2022
@oliviertassinari
Copy link
Member

@mnajdova I'm not sure that #32886 is working. It didn't seem to broke the CI on this PR, nor in #33009.

@mnajdova
Copy link
Member

@mnajdova I'm not sure that #32886 is working. It didn't seem to broke the CI on this PR, nor in #33009.

Could be because the PRs were open before the check was added.

@Janpot
Copy link
Member Author

Janpot commented Jun 24, 2022

I've definitely seen CI break on my last two PRs because of missing labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: alert This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants