Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Slider Label is broken in landing page #33355

Closed
2 tasks done
PunitSoniME opened this issue Jul 1, 2022 · 5 comments · Fixed by #33009
Closed
2 tasks done

[website] Slider Label is broken in landing page #33355

PunitSoniME opened this issue Jul 1, 2022 · 5 comments · Fixed by #33009
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! regression A bug, but worse website Pages that are not documentation-related, marketing-focused.

Comments

@PunitSoniME
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

No response

Expected behavior 🤔

No response

Steps to reproduce 🕹

Steps:

  1. Open material ui website https://mui.com/ and check the slider

image

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@PunitSoniME PunitSoniME added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 1, 2022
@michaldudak
Copy link
Member

It's likely a regression introduced in #32919. Would you like to give fixing it a try?

@michaldudak michaldudak added bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! website Pages that are not documentation-related, marketing-focused. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 1, 2022
@michaldudak michaldudak changed the title Slider Label is broken in landing page [website] Slider Label is broken in landing page Jul 1, 2022
@PunitSoniME
Copy link
Contributor Author

@michaldudak

Sure, let me give this a try

@abhinav-22-tech
Copy link
Contributor

This is already in process #33009
Please check this: https://deploy-preview-33009--material-ui.netlify.app/

@PunitSoniME
Copy link
Contributor Author

@abhinav-22-tech cool. Thanks for working on this

@michaldudak
as @abhinav-22-tech has also fixed this issue, we can close this task

@michaldudak michaldudak linked a pull request Jul 11, 2022 that will close this issue
[Slider] Fix transition of tooltips on vertical slider #33009
Merged
1 task
@michaldudak
Copy link
Member

@PunitSoniME It'll be closed when #33009 is merged.

@oliviertassinari oliviertassinari mentioned this issue Jul 15, 2022
Merged
1 task
@oliviertassinari oliviertassinari added the regression A bug, but worse label Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! regression A bug, but worse website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Slider] Fix transition of tooltips on vertical slider abhinav-22-tech/material-ui
4 participants
@oliviertassinari @michaldudak @PunitSoniME @abhinav-22-tech