[pickers] Remove make* HOCs
#25172
Merged
[pickers] Remove make* HOCs
#25172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
the
component: pickers
|
@material-ui/lab: parsed: +3.59% , gzip: +1.11% |
eps1lon
force-pushed
the
chore/pickers/inline-hocs
branch
3 times, most recently
from
1674941 to
ef3134e
Compare
eps1lon
force-pushed
the
chore/pickers/inline-hocs
branch
5 times, most recently
from
357f725 to
c00ce51
Compare
github-actions
bot
added
the
PR: out-of-date
eps1lon
force-pushed
the
chore/pickers/inline-hocs
branch
from
c00ce51 to
8e72a9b
Compare
github-actions
bot
removed
the
PR: out-of-date
eps1lon
force-pushed
the
chore/pickers/inline-hocs
branch
3 times, most recently
from
b521dde to
4b43025
Compare
eps1lon
force-pushed
the
chore/pickers/inline-hocs
branch
3 times, most recently
from
6738165 to
de18e07
Compare
eps1lon
force-pushed
the
chore/pickers/inline-hocs
branch
from
316f472 to
2ba7621
Compare
eps1lon
force-pushed
the
chore/pickers/inline-hocs
branch
from
2ba7621 to
dd958dd
Compare
For static analysis
|
Merging to continue work. |
This was referenced Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal change only. If this PR broke your code, please open an issue.
Review on a per commit basis is advised without whitespace changes.
Enables a bunch of type related simplification. I could go further but this is already hard to review.
Plan (this PR):
makePickerWithStatecall in each variant (responsive, desktop, mobile)makeWrapperComponentFrom there we can hopefully simplify interface or implementation. "Simplify" does not necessarily mean add another abstraction. If we add another abstraction it has to serve a purpose other than "DRY out the code". Hopefully drawing clearer boundaries results in a more reasonable composition which naturally allows React to optimize rendering (e.g. children memoization.