Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Remove make* HOCs #25172

Merged
merged 31 commits into from
Mar 12, 2021
Merged

[pickers] Remove make* HOCs #25172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e725ac9
[DesktopDatePicker] Inline `makePickerWithState` call
eps1lon Mar 3, 2021
d4876a6
[MobileDatePicker] Inline `makePickerWithState` call
eps1lon Mar 4, 2021
d7d9ab8
[DatePicker] Inline `makePickerWithState` call
eps1lon Mar 4, 2021
dbdaf94
[DesktopTimePicker] Inline `makePickerWithState` call
eps1lon Mar 4, 2021
8ea1bce
[MobileTimePicker] Inline `makePickerWithState` call
eps1lon Mar 4, 2021
4eeb03d
[TimePicker] Inline `makePickerWithState` call
eps1lon Mar 4, 2021
8aade47
[DesktopDateTimePicker] Inline `makePickerWithState` call
eps1lon Mar 4, 2021
88e8bc3
[MobileDateTimePicker] Inline `makePickerWithState` call
eps1lon Mar 4, 2021
eeb688a
[DateTimePicker] Inline `makePickerWithState` call
eps1lon Mar 4, 2021
ea1031d
[DesktopDatePicker] Inline `makeWrapper` call
eps1lon Mar 8, 2021
a5b52c5
[MobileDatePicker] Inline `makeWrapper` call
eps1lon Mar 8, 2021
a08f39b
[DatePicker] Inline `makeWrapper` call
eps1lon Mar 8, 2021
d60f6b1
[DesktopTimePicker] Inline `makeWrapper` call
eps1lon Mar 8, 2021
b4b9d24
[MobileTimePicker] Inline `makeWrapper` call
eps1lon Mar 8, 2021
cf455ad
[TimePicker] Inline `makeWrapper` call
eps1lon Mar 8, 2021
45e229d
[DesktopDateTimePicker] Inline `makeWrapper` call
eps1lon Mar 8, 2021
1db9610
[MobileDateTimePicker] Inline `makeWrapper` call
eps1lon Mar 8, 2021
188be6d
[DateTimePicker] Inline `makeWrapper` call
eps1lon Mar 8, 2021
941caf8
[StaticDatePicker] Inline `makePickerWithState` call
eps1lon Mar 8, 2021
69af98c
[StaticTimePicker] Inline `makePickerWithState` call
eps1lon Mar 8, 2021
57a84bc
[StaticDateTimePicker] Inline `makePickerWithState` call
eps1lon Mar 10, 2021
acf5695
[lab] Remove unused internal `makePickerWithState`
eps1lon Mar 10, 2021
1c26061
[StaticDatePicker] Inline `makeWrapper` call
eps1lon Mar 10, 2021
b1a17da
[StaticTimePicker] Inline `makeWrapper` call
eps1lon Mar 10, 2021
77335ac
[StaticDateTimePicker] Inline `makeWrapper` call
eps1lon Mar 10, 2021
329167f
[makeDateRangePicker] Inline `makeWrapper` call
eps1lon Mar 10, 2021
227e834
[makeWrapperComponent] Remove unused abstraction
eps1lon Mar 10, 2021
75605a5
Inline intermediate variables
eps1lon Mar 11, 2021
9843b4b
Create dedicated interface for *PickerWrapper components
eps1lon Mar 11, 2021
dd958dd
Use dedicated interface for *Picker components
eps1lon Mar 11, 2021
5ed613b
__props -> inProps
eps1lon Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 35 additions & 13 deletions docs/pages/api-docs/date-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,35 +2,49 @@
"props": {
"onChange": { "type": { "name": "func" }, "required": true },
"renderInput": { "type": { "name": "func" }, "required": true },
"acceptRegex": { "type": { "name": "instanceOf", "description": "RegExp" } },
"acceptRegex": {
"type": { "name": "instanceOf", "description": "RegExp" },
"default": "/\\dap/gi"
},
"allowKeyboardControl": { "type": { "name": "bool" } },
"allowSameDateSelection": { "type": { "name": "bool" } },
"cancelText": { "type": { "name": "node" } },
"cancelText": { "type": { "name": "node" }, "default": "\"CANCEL\"" },
"className": { "type": { "name": "string" } },
"clearable": { "type": { "name": "bool" } },
"clearText": { "type": { "name": "node" } },
"clearText": { "type": { "name": "node" }, "default": "\"CLEAR\"" },
"components": {
"type": {
"name": "shape",
"description": "{ LeftArrowButton?: elementType, LeftArrowIcon?: elementType, RightArrowButton?: elementType, RightArrowIcon?: elementType, SwitchViewButton?: elementType, SwitchViewIcon?: elementType }"
}
},
"default": "{}"
},
"componentsProps": { "type": { "name": "object" } },
"componentsProps": { "type": { "name": "object" }, "default": "{}" },
"defaultCalendarMonth": { "type": { "name": "any" } },
"desktopModeMediaQuery": {
"type": { "name": "string" },
"default": "\"@media (pointer: fine)\""
},
"DialogProps": { "type": { "name": "object" } },
"disableCloseOnSelect": { "type": { "name": "bool" } },
"disableCloseOnSelect": {
"type": { "name": "bool" },
"default": "`true` for Desktop, `false` for Mobile (based on the chosen wrapper and `desktopModeMediaQuery` prop)."
},
"disabled": { "type": { "name": "bool" } },
"disableHighlightToday": { "type": { "name": "bool" } },
"disableMaskedInput": { "type": { "name": "bool" } },
"disableOpenPicker": { "type": { "name": "bool" } },
"getOpenDialogAriaText": { "type": { "name": "func" } },
"getOpenDialogAriaText": {
"type": { "name": "func" },
"default": "(value, utils) => `Choose date, selected date is ${utils.format(utils.date(value), 'fullDate')}`"
},
"getViewSwitchingButtonText": { "type": { "name": "func" } },
"InputAdornmentProps": { "type": { "name": "object" } },
"inputFormat": { "type": { "name": "string" } },
"leftArrowButtonText": { "type": { "name": "string" } },
"loading": { "type": { "name": "bool" } },
"mask": { "type": { "name": "string" } },
"okText": { "type": { "name": "node" } },
"okText": { "type": { "name": "node" }, "default": "\"OK\"" },
"onAccept": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
Expand All @@ -50,22 +64,30 @@
"orientation": {
"type": { "name": "enum", "description": "'landscape'<br>&#124;&nbsp;'portrait'" }
},
"PopperProps": { "type": { "name": "object" } },
"readOnly": { "type": { "name": "bool" } },
"reduceAnimations": { "type": { "name": "bool" } },
"reduceAnimations": {
"type": { "name": "bool" },
"default": "typeof navigator !== 'undefined' && /(android)/i.test(navigator.userAgent)"
},
"renderDay": { "type": { "name": "func" } },
"renderLoading": { "type": { "name": "func" } },
"renderLoading": {
"type": { "name": "func" },
"default": "() => <span data-mui-test=\"loading-progress\">...</span>"
},
"rifmFormatter": { "type": { "name": "func" } },
"rightArrowButtonText": { "type": { "name": "string" } },
"shouldDisableDate": { "type": { "name": "func" } },
"shouldDisableYear": { "type": { "name": "func" } },
"showDaysOutsideCurrentMonth": { "type": { "name": "bool" } },
"showTodayButton": { "type": { "name": "bool" } },
"showToolbar": { "type": { "name": "bool" } },
"todayText": { "type": { "name": "node" } },
"todayText": { "type": { "name": "node" }, "default": "\"TODAY\"" },
"ToolbarComponent": { "type": { "name": "elementType" } },
"toolbarFormat": { "type": { "name": "string" } },
"toolbarPlaceholder": { "type": { "name": "node" } },
"toolbarTitle": { "type": { "name": "node" } },
"toolbarPlaceholder": { "type": { "name": "node" }, "default": "\"–\"" },
"toolbarTitle": { "type": { "name": "node" }, "default": "\"SELECT DATE\"" },
"TransitionComponent": { "type": { "name": "elementType" } },
"value": {
"type": {
"name": "union",
Expand Down
54 changes: 38 additions & 16 deletions docs/pages/api-docs/date-time-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,34 +2,50 @@
"props": {
"onChange": { "type": { "name": "func" }, "required": true },
"renderInput": { "type": { "name": "func" }, "required": true },
"acceptRegex": { "type": { "name": "instanceOf", "description": "RegExp" } },
"acceptRegex": {
"type": { "name": "instanceOf", "description": "RegExp" },
"default": "/\\dap/gi"
},
"allowKeyboardControl": { "type": { "name": "bool" } },
"allowSameDateSelection": { "type": { "name": "bool" } },
"ampm": { "type": { "name": "bool" } },
"ampmInClock": { "type": { "name": "bool" } },
"cancelText": { "type": { "name": "node" } },
"cancelText": { "type": { "name": "node" }, "default": "\"CANCEL\"" },
"className": { "type": { "name": "string" } },
"clearable": { "type": { "name": "bool" } },
"clearText": { "type": { "name": "node" } },
"clearText": { "type": { "name": "node" }, "default": "\"CLEAR\"" },
"components": {
"type": {
"name": "shape",
"description": "{ LeftArrowButton?: elementType, LeftArrowIcon?: elementType, RightArrowButton?: elementType, RightArrowIcon?: elementType, SwitchViewButton?: elementType, SwitchViewIcon?: elementType }"
}
},
"default": "{}"
},
"componentsProps": { "type": { "name": "object" } },
"componentsProps": { "type": { "name": "object" }, "default": "{}" },
"dateRangeIcon": { "type": { "name": "node" } },
"defaultCalendarMonth": { "type": { "name": "any" } },
"desktopModeMediaQuery": { "type": { "name": "string" } },
"desktopModeMediaQuery": {
"type": { "name": "string" },
"default": "\"@media (pointer: fine)\""
},
"DialogProps": { "type": { "name": "object" } },
"disableCloseOnSelect": { "type": { "name": "bool" } },
"disableCloseOnSelect": {
"type": { "name": "bool" },
"default": "`true` for Desktop, `false` for Mobile (based on the chosen wrapper and `desktopModeMediaQuery` prop)."
},
"disabled": { "type": { "name": "bool" } },
"disableHighlightToday": { "type": { "name": "bool" } },
"disableIgnoringDatePartForTimeValidation": { "type": { "name": "bool" } },
"disableMaskedInput": { "type": { "name": "bool" } },
"disableOpenPicker": { "type": { "name": "bool" } },
"getClockLabelText": { "type": { "name": "func" } },
"getOpenDialogAriaText": { "type": { "name": "func" } },
"getClockLabelText": {
"type": { "name": "func" },
"default": "<TDate extends any>(\n view: 'hours' | 'minutes' | 'seconds',\n time: TDate,\n adapter: MuiPickersAdapter<TDate>,\n) => `Select ${view}. Selected time is ${adapter.format(time, 'fullTime')}`"
},
"getOpenDialogAriaText": {
"type": { "name": "func" },
"default": "(value, utils) => `Choose date, selected date is ${utils.format(utils.date(value), 'fullDate')}`"
},
"getViewSwitchingButtonText": { "type": { "name": "func" } },
"hideTabs": { "type": { "name": "bool" } },
"InputAdornmentProps": { "type": { "name": "object" } },
Expand All @@ -49,8 +65,8 @@
"description": "any<br>&#124;&nbsp;Date<br>&#124;&nbsp;number<br>&#124;&nbsp;string"
}
},
"minutesStep": { "type": { "name": "number" } },
"okText": { "type": { "name": "node" } },
"minutesStep": { "type": { "name": "number" }, "default": "1" },
"okText": { "type": { "name": "node" }, "default": "\"OK\"" },
"onAccept": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
Expand All @@ -72,9 +88,15 @@
},
"PopperProps": { "type": { "name": "object" } },
"readOnly": { "type": { "name": "bool" } },
"reduceAnimations": { "type": { "name": "bool" } },
"reduceAnimations": {
"type": { "name": "bool" },
"default": "typeof navigator !== 'undefined' && /(android)/i.test(navigator.userAgent)"
},
"renderDay": { "type": { "name": "func" } },
"renderLoading": { "type": { "name": "func" } },
"renderLoading": {
"type": { "name": "func" },
"default": "() => <span data-mui-test=\"loading-progress\">...</span>"
},
"rifmFormatter": { "type": { "name": "func" } },
"rightArrowButtonText": { "type": { "name": "string" } },
"shouldDisableDate": { "type": { "name": "func" } },
Expand All @@ -84,11 +106,11 @@
"showTodayButton": { "type": { "name": "bool" } },
"showToolbar": { "type": { "name": "bool" } },
"timeIcon": { "type": { "name": "node" } },
"todayText": { "type": { "name": "node" } },
"todayText": { "type": { "name": "node" }, "default": "\"TODAY\"" },
"ToolbarComponent": { "type": { "name": "elementType" } },
"toolbarFormat": { "type": { "name": "string" } },
"toolbarPlaceholder": { "type": { "name": "node" } },
"toolbarTitle": { "type": { "name": "node" } },
"toolbarPlaceholder": { "type": { "name": "node" }, "default": "\"–\"" },
"toolbarTitle": { "type": { "name": "node" }, "default": "\"SELECT DATE\"" },
"TransitionComponent": { "type": { "name": "elementType" } },
"value": {
"type": {
Expand Down
34 changes: 25 additions & 9 deletions docs/pages/api-docs/desktop-date-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,34 @@
"props": {
"onChange": { "type": { "name": "func" }, "required": true },
"renderInput": { "type": { "name": "func" }, "required": true },
"acceptRegex": { "type": { "name": "instanceOf", "description": "RegExp" } },
"acceptRegex": {
"type": { "name": "instanceOf", "description": "RegExp" },
"default": "/\\dap/gi"
},
"allowKeyboardControl": { "type": { "name": "bool" } },
"allowSameDateSelection": { "type": { "name": "bool" } },
"className": { "type": { "name": "string" } },
"components": {
"type": {
"name": "shape",
"description": "{ LeftArrowButton?: elementType, LeftArrowIcon?: elementType, RightArrowButton?: elementType, RightArrowIcon?: elementType, SwitchViewButton?: elementType, SwitchViewIcon?: elementType }"
}
},
"default": "{}"
},
"componentsProps": { "type": { "name": "object" } },
"componentsProps": { "type": { "name": "object" }, "default": "{}" },
"defaultCalendarMonth": { "type": { "name": "any" } },
"disableCloseOnSelect": { "type": { "name": "bool" } },
"disableCloseOnSelect": {
"type": { "name": "bool" },
"default": "`true` for Desktop, `false` for Mobile (based on the chosen wrapper and `desktopModeMediaQuery` prop)."
},
"disabled": { "type": { "name": "bool" } },
"disableHighlightToday": { "type": { "name": "bool" } },
"disableMaskedInput": { "type": { "name": "bool" } },
"disableOpenPicker": { "type": { "name": "bool" } },
"getOpenDialogAriaText": { "type": { "name": "func" } },
"getOpenDialogAriaText": {
"type": { "name": "func" },
"default": "(value, utils) => `Choose date, selected date is ${utils.format(utils.date(value), 'fullDate')}`"
},
"getViewSwitchingButtonText": { "type": { "name": "func" } },
"InputAdornmentProps": { "type": { "name": "object" } },
"inputFormat": { "type": { "name": "string" } },
Expand Down Expand Up @@ -47,9 +57,15 @@
},
"PopperProps": { "type": { "name": "object" } },
"readOnly": { "type": { "name": "bool" } },
"reduceAnimations": { "type": { "name": "bool" } },
"reduceAnimations": {
"type": { "name": "bool" },
"default": "typeof navigator !== 'undefined' && /(android)/i.test(navigator.userAgent)"
},
"renderDay": { "type": { "name": "func" } },
"renderLoading": { "type": { "name": "func" } },
"renderLoading": {
"type": { "name": "func" },
"default": "() => <span data-mui-test=\"loading-progress\">...</span>"
},
"rifmFormatter": { "type": { "name": "func" } },
"rightArrowButtonText": { "type": { "name": "string" } },
"shouldDisableDate": { "type": { "name": "func" } },
Expand All @@ -58,8 +74,8 @@
"showToolbar": { "type": { "name": "bool" } },
"ToolbarComponent": { "type": { "name": "elementType" } },
"toolbarFormat": { "type": { "name": "string" } },
"toolbarPlaceholder": { "type": { "name": "node" } },
"toolbarTitle": { "type": { "name": "node" } },
"toolbarPlaceholder": { "type": { "name": "node" }, "default": "\"–\"" },
"toolbarTitle": { "type": { "name": "node" }, "default": "\"SELECT DATE\"" },
"TransitionComponent": { "type": { "name": "elementType" } },
"value": {
"type": {
Expand Down
41 changes: 30 additions & 11 deletions docs/pages/api-docs/desktop-date-time-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
"props": {
"onChange": { "type": { "name": "func" }, "required": true },
"renderInput": { "type": { "name": "func" }, "required": true },
"acceptRegex": { "type": { "name": "instanceOf", "description": "RegExp" } },
"acceptRegex": {
"type": { "name": "instanceOf", "description": "RegExp" },
"default": "/\\dap/gi"
},
"allowKeyboardControl": { "type": { "name": "bool" } },
"allowSameDateSelection": { "type": { "name": "bool" } },
"ampm": { "type": { "name": "bool" } },
Expand All @@ -12,19 +15,29 @@
"type": {
"name": "shape",
"description": "{ LeftArrowButton?: elementType, LeftArrowIcon?: elementType, RightArrowButton?: elementType, RightArrowIcon?: elementType, SwitchViewButton?: elementType, SwitchViewIcon?: elementType }"
}
},
"default": "{}"
},
"componentsProps": { "type": { "name": "object" } },
"componentsProps": { "type": { "name": "object" }, "default": "{}" },
"dateRangeIcon": { "type": { "name": "node" } },
"defaultCalendarMonth": { "type": { "name": "any" } },
"disableCloseOnSelect": { "type": { "name": "bool" } },
"disableCloseOnSelect": {
"type": { "name": "bool" },
"default": "`true` for Desktop, `false` for Mobile (based on the chosen wrapper and `desktopModeMediaQuery` prop)."
},
"disabled": { "type": { "name": "bool" } },
"disableHighlightToday": { "type": { "name": "bool" } },
"disableIgnoringDatePartForTimeValidation": { "type": { "name": "bool" } },
"disableMaskedInput": { "type": { "name": "bool" } },
"disableOpenPicker": { "type": { "name": "bool" } },
"getClockLabelText": { "type": { "name": "func" } },
"getOpenDialogAriaText": { "type": { "name": "func" } },
"getClockLabelText": {
"type": { "name": "func" },
"default": "<TDate extends any>(\n view: 'hours' | 'minutes' | 'seconds',\n time: TDate,\n adapter: MuiPickersAdapter<TDate>,\n) => `Select ${view}. Selected time is ${adapter.format(time, 'fullTime')}`"
},
"getOpenDialogAriaText": {
"type": { "name": "func" },
"default": "(value, utils) => `Choose date, selected date is ${utils.format(utils.date(value), 'fullDate')}`"
},
"getViewSwitchingButtonText": { "type": { "name": "func" } },
"hideTabs": { "type": { "name": "bool" } },
"InputAdornmentProps": { "type": { "name": "object" } },
Expand All @@ -44,7 +57,7 @@
"description": "any<br>&#124;&nbsp;Date<br>&#124;&nbsp;number<br>&#124;&nbsp;string"
}
},
"minutesStep": { "type": { "name": "number" } },
"minutesStep": { "type": { "name": "number" }, "default": "1" },
"onAccept": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
Expand All @@ -66,9 +79,15 @@
},
"PopperProps": { "type": { "name": "object" } },
"readOnly": { "type": { "name": "bool" } },
"reduceAnimations": { "type": { "name": "bool" } },
"reduceAnimations": {
"type": { "name": "bool" },
"default": "typeof navigator !== 'undefined' && /(android)/i.test(navigator.userAgent)"
},
"renderDay": { "type": { "name": "func" } },
"renderLoading": { "type": { "name": "func" } },
"renderLoading": {
"type": { "name": "func" },
"default": "() => <span data-mui-test=\"loading-progress\">...</span>"
},
"rifmFormatter": { "type": { "name": "func" } },
"rightArrowButtonText": { "type": { "name": "string" } },
"shouldDisableDate": { "type": { "name": "func" } },
Expand All @@ -79,8 +98,8 @@
"timeIcon": { "type": { "name": "node" } },
"ToolbarComponent": { "type": { "name": "elementType" } },
"toolbarFormat": { "type": { "name": "string" } },
"toolbarPlaceholder": { "type": { "name": "node" } },
"toolbarTitle": { "type": { "name": "node" } },
"toolbarPlaceholder": { "type": { "name": "node" }, "default": "\"–\"" },
"toolbarTitle": { "type": { "name": "node" }, "default": "\"SELECT DATE\"" },
"TransitionComponent": { "type": { "name": "elementType" } },
"value": {
"type": {
Expand Down
Loading