Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StaticDateRangePicker] Fix inconsistent name for theme props #25483

Merged
merged 4 commits into from
Mar 25, 2021
Merged

[StaticDateRangePicker] Fix inconsistent name for theme props #25483

merged 4 commits into from
Mar 25, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 24, 2021

BREAKING CHANGE

The name in the theme for setting default props for the StaticDateRangePicker is now MuiStaticDateRangePicker (was MuiPickersDateRangePicker).

Added a lint rule to guard against future mistakes. This also makes sure that their display name (if not manually overridden) is consistent.

Part of the changes are cleaning up after #25172

@eps1lon eps1lon added breaking change component: date range picker This is the name of the generic UI component, not the React module! labels Mar 24, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 24, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 9113a61

@eps1lon eps1lon marked this pull request as ready for review March 24, 2021 16:12
@github-actions github-actions bot mentioned this pull request Mar 24, 2021
Closed
oliviertassinari
oliviertassinari approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised there isn't more inconsistencies in the codebase. Now, we can't get it wrong with this eslint rule :)

@eps1lon eps1lon merged commit 85aa846 into mui:next Mar 25, 2021
@eps1lon eps1lon deleted the feat/consistent-mui-name branch March 25, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change component: date range picker This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari