Add fields for Nginx and Nginx stub metricset

[mrkschan]

No description provided.

[mrkschan]

@ruflin Could you check if I miss anything here?

[ruflin]

Could make sense to switch this to "long" as "integer" could overflow here.

[mrkschan]

Do you mean we better not to use Atoi()?

[ruflin]

Good point, was not thinking of the implementation itself. The question here is what nginx will report as a max value and if it will exceed int or not. We hit some issues here recently in topbeat and filebeat where we use integer and switched to long as the values got too big.

[mrkschan]

I think i would keep integer here until we no longer user Atoi() :)

[ruflin]

LGTM

[mrkschan]

@ruflin when I run scripts/fields_collector.py, the metricbeat/etc/fields_base.yml is not included, do I miss something?

[ruflin]

@mrkschan Run make collect. That should do the trick. I really have to document that ...

[mrkschan]

@ruflin did so :) does this still look good?

[ruflin]

Definitively.

[mrkschan]

@ruflin Do you know what break CI https://travis-ci.org/mrkschan/beats/jobs/127222650#L404?

[ruflin]

It seems to look for an nginx environment which doesn't exist:

build path /home/travis/gopath/src/github.com/elastic/beats/testing/environments/tests/environments/nginx

[ruflin]

@mrkschan We just made a bigger refactoring of metricbeat which probably also affects a few line in the nginx module (elastic#1549). Me and @andrewkroh would be happy to open a PR against your branch to make it compatible again.

[mrkschan]

@ruflin thanks :)