forked from elastic/beats
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fields for Nginx and Nginx stub metricset #2
Merged
mrkschan
merged 2 commits into
metricbeat-nginx-module
from
metricbeat-nginx-stub-fields
May 14, 2016
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
nginx: | ||
type: group | ||
description: > | ||
Nginx server status metrics collected from various modules. | ||
fields: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
- name: nginx-stubstatus | ||
type: group | ||
description: > | ||
`nginx-stubstatus` contains the metrics that were scraped from the ngx_http_stub_status_module status page. | ||
fields: | ||
- name: hostname | ||
type: keyword | ||
description: > | ||
Nginx hostname | ||
- name: active | ||
type: integer | ||
description: > | ||
The current number of active client connections including Waiting connections. | ||
- name: accepts | ||
type: integer | ||
description: > | ||
The total number of accepted client connections. | ||
- name: handled | ||
type: integer | ||
description: > | ||
The total number of handled client connections. | ||
- name: dropped | ||
type: integer | ||
description: > | ||
The total number of dropped client connections. | ||
- name: requests | ||
type: integer | ||
description: > | ||
The total number of client requests. | ||
- name: current | ||
type: integer | ||
description: > | ||
The current number of client requests. | ||
- name: reading | ||
type: integer | ||
description: > | ||
The current number of connections where nginx is reading the request header. | ||
- name: writing | ||
type: integer | ||
description: > | ||
The current number of connections where nginx is writing the response back to the client. | ||
- name: waiting | ||
type: integer | ||
description: > | ||
The current number of idle client connections waiting for a request. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could make sense to switch this to "long" as "integer" could overflow here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean we better not to use
Atoi()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, was not thinking of the implementation itself. The question here is what nginx will report as a max value and if it will exceed int or not. We hit some issues here recently in topbeat and filebeat where we use
integer
and switched tolong
as the values got too big.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i would keep
integer
here until we no longer userAtoi()
:)