Add Nginx stub status to metricbeat #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 10, 2016 23:44
Add Nginx module with stub status metric set
Conflicts: metricbeat/etc/beat.yml metricbeat/include/list.go metricbeat/metricbeat.yml
Conflicts: metricbeat/docker-entrypoint.sh metricbeat/docs/fields.asciidoc metricbeat/etc/beat.yml metricbeat/etc/fields.yml metricbeat/etc/fields_base.yml metricbeat/metricbeat.template-es2x.json metricbeat/metricbeat.template.json metricbeat/metricbeat.yml metricbeat/module/nginx/*
|
|
||
| === Example Configuration | ||
|
|
||
| The Apache module supports the standard configuration options which can be found |
|
Looks good, I just had a few minor comments. Thanks for your contribution! |
|
@mrkschan Thanks a lot for the contribution and already integrating our most recent metricbeat changes. I'm happy to merge it as it is and do the changes found by @andrewkroh afterwards so we can help with it, or you can push them yourself. What do you prefer? |
|
fixed, please let me do if there's any other issue :) |
|
@mrkschan All good. Thanks a lot 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.