Allow automatic print rotation via the enablePrintAutoRotate preference #8043

Rob--W · 2017-02-07T23:21:36Z

Tests:

gulp server
Download test1.pdf and test2.pdf (courtesy of Support printing page with different rotation #6103) and save them to the pdf.js repo.
Open the viewer, run PDFViewerApplication.preferences.set('enablePrintAutoRotate', true); and refresh.
Press Ctrl + P within the page (or click on the print button).
Verify that the pages have the same orientation.
Repeat step 3 - 5 for test1.pdf
Repeat step 3 with false instead of true, then perform step 4 and confirm that the page rotation did not change.

Fixes #6696, supersedes #6103

Determine the page rotation at the same place as where the page size is determined. This allows us to implement custom print page rotation logic in one place, in the future.

Rob--W · 2017-02-07T23:22:09Z

/botio-linux preview

timvandermeij

This solution looks really clean! After addressing the comment, I'll do more testing before approving this.

timvandermeij · 2017-02-07T23:42:05Z

web/app.js

@@ -1457,6 +1460,9 @@ function webViewerInitialized() {
    if ('useonlycsszoom' in hashParams) {
      PDFJS.useOnlyCssZoom = (hashParams['useonlycsszoom'] === 'true');
    }
+    if ('printautorotate' in hashParams) {


Remove the hash parameter addition. The hash parameters are only used for debugging purposes, not for toggling features. Moreover, using the preferences for this is preferred and quite a few hash parameters have already been removed before.

How would you test the parameter in the web viewer without the hash param? I only added it in order to test it from the test server.

How would you test the parameter in the web viewer without the hash param?

E.g. by executing PDFViewerApplication.preferences.set('enablePrintAutoRotate', {true, false}); in the console and then reloading the viewer.

Furthermore, we shouldn't be adding new things to PDFJS especially not in the viewer, since the usage of PDFJS will most likely be removed in future PDF.js versions.
Can we please just pass the preference into PDFViewer in the same way as e.g. the enhanceTextSelection preference is handled instead!?

Thank you!
Can you please also add a JSDoc comment for the new PDFViewer parameter at https://github.com/mozilla/pdf.js/blob/master/web/pdf_viewer.js#L69?

Rob--W · 2017-02-08T10:37:30Z

/botio-linux preview

timvandermeij · 2017-02-08T21:44:12Z

/botio-linux preview

pdfjsbot · 2017-02-08T21:44:12Z

From: Bot.io (Linux)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/47ff66d588af8e9/output.txt

pdfjsbot · 2017-02-08T21:46:23Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/47ff66d588af8e9/output.txt

Total script time: 2.17 mins

Published

timvandermeij · 2017-02-08T22:57:53Z

Thank you for implementing this!

Piita · 2017-06-13T16:32:27Z

I'm not sure if I'm reading all of this correctly. I have my default pdf view set as "Preview in Firefox." When I print from that viewer, the pdf prints in whatever orientation my printer settings are set at. My printer dialog does not allow me to auto detect page orientation for printing, so in order to change the orientation I have to do it on a per document basis. I tried the solution for PDFViewerApplication.preferences.set('enablePrintAutoRotate', true), but when I run about:config, I do not find either portion of that as an option in my list of commands. I am running Windows 10 and trying to dump Chrome because it lags so badly, but this printing issue is a major issue that will keep me from changing. Can you help?

timvandermeij · 2017-06-13T20:45:07Z

I have [email protected] in about:config, but that is most likely because I have the development add-on installed. I'm not sure how to find it using the regular Firefox build. Maybe others have an idea here? If it works well, we may also consider enabling it by default in a separate issue.

Piita · 2017-06-14T15:01:20Z

Thank you for your quick response! If it will resolve this one problem for me, do you think I should add the developer add-on? I have had so much trouble with Chrome, and it's gotten to the point that I just want to dump it. This issue is my only hold-up with Firefox.

…

____________________________________________________________

___________________________

On Tue, Jun 13, 2017 at 4:45 PM, Tim van der Meij ***@***.***> wrote: I have ***@***.*** in about:config, but that is most likely because I have the development add-on installed. I'm not sure how to find it using the regular Firefox build. Maybe others have an idea here? If it works well, we may also consider enabling it by default in a separate issue. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8043 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcC8P3iqkOs9836uqw9-1OOFh9dR0Ahiks5sDvT_gaJpZM4L6LKj> .

yurydelendik · 2017-06-14T15:33:28Z

pdfjs.enablePrintAutoRotate key is used for firefox embedded preference

yurydelendik · 2017-06-14T15:39:40Z

Firefox 54 per https://bugzilla.mozilla.org/show_bug.cgi?id=1338395

timvandermeij · 2017-06-14T22:15:02Z

@Piita It is recommended to just update to Firefox 54. Per the link above, it should have the pdfjs.enablePrintAutoRotate key in about:config then so you can toggle it. There should be no need to install the developer add-on.

Piita · 2017-06-15T00:24:54Z

Okay, I don't know what I'm doing wrong. I've updated to Firefox 54. I have the following settings in about:config - print.use_global_printsettings;false pdfjs.enablePrintAutoRotate;true The problem I'm having is that when I preview a PDF file attached to a Gmail email, I have it set to "Preview in Firefox" so I assume it's using Firefox's pdf viewer. When I view it and click on the printer icon in the viewer screen, it shows it in the proper landscape orientation, but when it prints it prints in portrait orientation; I assume it does this because my the setting on the printer itself defaults to portrait, and the print dialog in Firefox also defaults to portrait. This is why I set print.use_global_printsettings set to False, and wanted pdfjs. enablePrintAutoRotate set to True. Then, I restarted Firefox, opened the email message, viewed the PDF document in landscape, and it printed in portrait. I don't know what else to do. Is there any other setting that I need to pay attention to? I don't want to set my default to landscape, because not everything I print is in landscape. I don't want to have to manually change the print orientation for each document. I don't have to do that in Chrome or IE, which right now is their only saving grace. Attached is an example of the document in question. Maybe you can tell what else I can try?

…

_______________________________________________________________________________________

On Wed, Jun 14, 2017 at 6:15 PM, Tim van der Meij ***@***.***> wrote: @Piita <https://github.com/piita> It is recommended to just update to Firefox 54. Per the link above, it should have the pdfjs.enablePrintAutoRotate key in about:config then so you can toggle it. There should be no need to install the developer add-on. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8043 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcC8PxdEuF89T-I1E6J4H1vWUfRJuTy6ks5sEFuCgaJpZM4L6LKj> .

jscher2000 · 2017-12-07T00:09:45Z

@Piita, auto-rotate relates to how pages 2-n are drawn in relation to page 1. In other words, if page 1 is portrait and page 2 is landscape, page 2 will be rotated rather than shrunk-to-fit. However, pdf.js does not auto-detect the current page setup and rotate the first page in relation to that setting. That's issue #2851.

Allow automatic print rotation via the enablePrintAutoRotate preference

Refactor: configurable page rotation in print job

775441b

Determine the page rotation at the same place as where the page size is determined. This allows us to implement custom print page rotation logic in one place, in the future.

Rob--W added the printing label Feb 7, 2017

Rob--W requested a review from timvandermeij February 7, 2017 23:21

timvandermeij reviewed Feb 7, 2017

View reviewed changes

Rob--W force-pushed the issue6696-auto-rotate-page branch from 5ea1dfd to f95827c Compare February 8, 2017 10:35

Allow automatic print rotation via enablePrintAutoRotate

ece44d3

Rob--W force-pushed the issue6696-auto-rotate-page branch from f95827c to ece44d3 Compare February 8, 2017 12:59

timvandermeij merged commit 573236e into mozilla:master Feb 8, 2017

This was referenced Feb 8, 2017

Printing problems: Landscape to Portrait #4514

Closed

Rotate landscape to portrait while rendering pdf file in browser #6740

Closed

Chrome extension bug: Page 2 landscape stretched to page 1 portrait mode on print #6800

Closed

berenddeschouwer mentioned this pull request May 26, 2017

add paper size to document information #6990

Closed

movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018

Merge pull request mozilla#8043 from Rob--W/issue6696-auto-rotate-page

442d810

Allow automatic print rotation via the enablePrintAutoRotate preference

escapewindow mentioned this pull request Jun 25, 2020

Fix auto-rotate for printing landscape PDFs where the first page is also landscape #12023

Merged

mozilla deleted a comment from JonKim-bot Jul 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow automatic print rotation via the enablePrintAutoRotate preference #8043

Allow automatic print rotation via the enablePrintAutoRotate preference #8043

Rob--W commented Feb 7, 2017 •

edited

Loading

Rob--W commented Feb 7, 2017

timvandermeij left a comment

timvandermeij Feb 7, 2017

Rob--W Feb 8, 2017

Snuffleupagus Feb 8, 2017

Rob--W Feb 8, 2017

Snuffleupagus Feb 8, 2017

Rob--W commented Feb 8, 2017

timvandermeij commented Feb 8, 2017

pdfjsbot commented Feb 8, 2017

pdfjsbot commented Feb 8, 2017

timvandermeij commented Feb 8, 2017

Piita commented Jun 13, 2017

timvandermeij commented Jun 13, 2017

Piita commented Jun 14, 2017 via email

yurydelendik commented Jun 14, 2017

yurydelendik commented Jun 14, 2017

timvandermeij commented Jun 14, 2017

Piita commented Jun 15, 2017 via email

jscher2000 commented Dec 7, 2017

Allow automatic print rotation via the enablePrintAutoRotate preference #8043

Allow automatic print rotation via the enablePrintAutoRotate preference #8043

Conversation

Rob--W commented Feb 7, 2017 • edited Loading

Rob--W commented Feb 7, 2017

timvandermeij left a comment

Choose a reason for hiding this comment

timvandermeij Feb 7, 2017

Choose a reason for hiding this comment

Rob--W Feb 8, 2017

Choose a reason for hiding this comment

Snuffleupagus Feb 8, 2017

Choose a reason for hiding this comment

Rob--W Feb 8, 2017

Choose a reason for hiding this comment

Snuffleupagus Feb 8, 2017

Choose a reason for hiding this comment

Rob--W commented Feb 8, 2017

timvandermeij commented Feb 8, 2017

pdfjsbot commented Feb 8, 2017

From: Bot.io (Linux)

Received

pdfjsbot commented Feb 8, 2017

From: Bot.io (Linux)

Success

Published

timvandermeij commented Feb 8, 2017

Piita commented Jun 13, 2017

timvandermeij commented Jun 13, 2017

Piita commented Jun 14, 2017 via email

yurydelendik commented Jun 14, 2017

yurydelendik commented Jun 14, 2017

timvandermeij commented Jun 14, 2017

Piita commented Jun 15, 2017 via email

jscher2000 commented Dec 7, 2017

Rob--W commented Feb 7, 2017 •

edited

Loading