[api-minor] Enables subpixel anti-aliasing for most of the content. #6551

yurydelendik · 2015-10-22T00:17:20Z

The existing mozOpaque logic does not work. Allowing subpixel aa by default, for special blend modes temporary canvas will be created (thus delaying output). The latter requires more memory, it is a trade-off in favor of having a better text output for majority content.

Initially canvas will be created hidden (to hide black flickering), however after first draw callback it will be shown. (Alternative was fill it white before render command, however it will break existing custom solutions)

I noticed that CachedCanvases are broken (global cache can be cleared in the middle of other page rendering) -- added local caches instead.

yurydelendik · 2015-10-22T00:17:28Z

/botio-linux preview

pdfjsbot · 2015-10-22T00:17:29Z

From: Bot.io (Linux)

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/fca3593656b1553/output.txt

pdfjsbot · 2015-10-22T00:18:09Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/fca3593656b1553/output.txt

Total script time: 0.67 mins

Published

Snuffleupagus · 2015-10-22T08:13:54Z

src/display/canvas.js

-        this.ctx.clearRect(0, 0, width, height);
-      } else {
-        this.ctx.mozOpaque = true;
+        var trasparentCanvas = CachedCanvases.getCanvas(


Nit: spelling trasparentCanvas -> transparentCanvas.

yurydelendik · 2015-10-22T13:10:49Z

/botio test

pdfjsbot · 2015-10-22T13:10:50Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/d2f49970dbf4ee6/output.txt

pdfjsbot · 2015-10-22T13:10:50Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5b8bf0a7d2d1215/output.txt

pdfjsbot · 2015-10-22T13:29:45Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/d2f49970dbf4ee6/output.txt

Total script time: 18.91 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/d2f49970dbf4ee6/reftest-analyzer.html#web=eq.log

pdfjsbot · 2015-10-22T13:30:58Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/5b8bf0a7d2d1215/output.txt

Total script time: 20.14 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/5b8bf0a7d2d1215/reftest-analyzer.html#web=eq.log

yurydelendik · 2015-10-22T14:06:11Z

Addresses #5196 and #4252.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1216906

(Past work at #4556)

yurydelendik · 2015-10-23T17:56:37Z

Minor version update due to transform property for RenderParameters

timvandermeij · 2015-10-24T12:42:21Z

Will this patch also fix #5197?

yurydelendik · 2015-10-24T12:45:36Z

Will that also fix #5197?

Not sure it will, {alpha: false} is recient api and mozOpaque is Firefox specific. So IE9 might be out of luck -- I could not find anything similar on MS side.

Snuffleupagus · 2015-10-24T13:24:17Z

Is it correct to assume that this patch also fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1161147?

yurydelendik · 2015-10-24T13:45:06Z

Correct.

brendandahl · 2015-10-28T22:19:05Z

If I'm following the logic in https://mxr.mozilla.org/mozilla-central/source/dom/html/HTMLCanvasElement.cpp correctly {alpha: false} and mozOpaque should achieve the same thing. Can we just remove all mozOpaques?

yurydelendik · 2015-10-28T22:36:01Z

{alpha: false} and mozOpaque should achieve the same thing

Correct, but it does not work on Nightly for Mac OSX. If I remove mozOpaque, the subpixel-aa is broken again (and still continue to work on Chrome)

yurydelendik · 2015-10-28T22:44:09Z

/botio-windows preview

pdfjsbot · 2015-10-28T22:44:09Z

From: Bot.io (Windows)

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/91506f4d9673871/output.txt

pdfjsbot · 2015-10-28T22:45:03Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/91506f4d9673871/output.txt

Total script time: 0.89 mins

Published

timvandermeij · 2015-10-29T21:49:08Z

Left is the current master, right is this patch (click to enlarge the uncompressed image). The differences are more visible if you open two tabs, one with https://mozilla.github.io/pdf.js/web/viewer.html and one with http://107.22.172.223:8877/91506f4d9673871/web/viewer.html, put both on the same position in the document and then switch tabs back and forth. In the comparison below, take a close look at the letters p (in "alternative paths" on the left side, fourth sentence from the bottom) and h to notice the difference. The italic words are also less blurry with this patch applied (example: "General terms" below is more crisp, i.e. it appears to have less "drop shadow").

pdfjsbot · 2015-10-30T22:04:51Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/fb87b189154cb88/output.txt

Total script time: 19.00 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/fb87b189154cb88/reftest-analyzer.html#web=eq.log

pdfjsbot · 2015-10-30T22:05:36Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/0d979471e9dd731/output.txt

Total script time: 19.75 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/0d979471e9dd731/reftest-analyzer.html#web=eq.log

brendandahl · 2015-10-30T22:20:33Z

geothermal and issue1655 are now black. Though, these seem to have regressed at some point.

yurydelendik · 2015-11-16T16:51:26Z

geothermal and issue1655 are now black. Though, these seem to have regressed at some point.

That's normal, not a regression -- those are skipped pages. I made them white again.

/botio test

pdfjsbot · 2015-11-16T16:51:27Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/680655fcb371a39/output.txt

pdfjsbot · 2015-11-16T16:51:27Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/6f43ad757305c2b/output.txt

pdfjsbot · 2015-11-16T17:10:24Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/680655fcb371a39/output.txt

Total script time: 18.96 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/680655fcb371a39/reftest-analyzer.html#web=eq.log

pdfjsbot · 2015-11-16T17:11:02Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/6f43ad757305c2b/output.txt

Total script time: 19.58 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/6f43ad757305c2b/reftest-analyzer.html#web=eq.log

brendandahl · 2015-11-18T01:18:10Z

/botio makeref

pdfjsbot · 2015-11-18T01:18:12Z

From: Bot.io (Linux)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ce060618d3cd473/output.txt

pdfjsbot · 2015-11-18T01:18:12Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/0839da959e79d99/output.txt

brendandahl · 2015-11-18T01:18:24Z

r+ merge away when make ref is done

pdfjsbot · 2015-11-18T01:37:07Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/0839da959e79d99/output.txt

Total script time: 18.90 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2015-11-18T01:38:13Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/ce060618d3cd473/output.txt

Total script time: 20.00 mins

Lint: Passed
Make references: Passed
Check references: Passed

[api-minor] Enables subpixel anti-aliasing for most of the content.

yurydelendik changed the title ~~[WIP] Enables subpixel anti-aliasing for most of the content.~~ Enables subpixel anti-aliasing for most of the content. Oct 22, 2015

Snuffleupagus reviewed Oct 22, 2015
View reviewed changes

timvandermeij added the core label Oct 22, 2015

yurydelendik force-pushed the subaa branch from 8650f34 to 9fe62cd Compare October 22, 2015 13:10

yurydelendik force-pushed the subaa branch 2 times, most recently from a9bcf9c to 402a732 Compare October 22, 2015 13:51

yurydelendik force-pushed the subaa branch from 402a732 to 7a5340c Compare October 22, 2015 14:17

yurydelendik changed the title ~~Enables subpixel anti-aliasing for most of the content.~~ [api-minor] Enables subpixel anti-aliasing for most of the content. Oct 23, 2015

yurydelendik mentioned this pull request Oct 23, 2015

Update version number for minor API changes. #6555

Merged

timvandermeij assigned brendandahl Oct 28, 2015

yurydelendik force-pushed the subaa branch from 7a5340c to 1edf3ad Compare November 16, 2015 16:44

Allow subpixel anti-aliasing for most of the content.

1d88003

yurydelendik force-pushed the subaa branch from 1edf3ad to 1d88003 Compare November 16, 2015 16:50

yurydelendik added a commit that referenced this pull request Nov 18, 2015

Merge pull request #6551 from yurydelendik/subaa

194994a

[api-minor] Enables subpixel anti-aliasing for most of the content.

yurydelendik merged commit 194994a into mozilla:master Nov 18, 2015

yurydelendik deleted the subaa branch November 18, 2015 01:46

yurydelendik mentioned this pull request Nov 18, 2015

Version 1.3 #6653

Merged

This was referenced Nov 18, 2015

Failure to do subpixel anti-aliasing #4252

Closed

all pages remain blank because the canvas remains hidden #6661

Closed

danez mentioned this pull request Dec 1, 2015

Black flickering while rendering #6709

Closed

Snuffleupagus mentioned this pull request Dec 4, 2015

Safari failed to render PDF #6001

Closed

Snuffleupagus mentioned this pull request Jan 6, 2016

Image not rendering correctly #5526

Closed

Snuffleupagus mentioned this pull request Jan 19, 2016

Rendering multiple pages at the same time sometimes does not work correctly #6477

Closed

Snuffleupagus mentioned this pull request Feb 4, 2016

PDF documents with transparent background cause page rendering to fail #6206

Closed

Snuffleupagus mentioned this pull request Sep 7, 2016

Page not displaied #7611

Closed

Snuffleupagus mentioned this pull request May 9, 2022

Try to remove the mozOpaque canvas-property (PR 6551 follow-up) #14894

Merged

[api-minor] Enables subpixel anti-aliasing for most of the content. #6551

[api-minor] Enables subpixel anti-aliasing for most of the content. #6551

Conversation

yurydelendik commented Oct 22, 2015

yurydelendik commented Oct 22, 2015

pdfjsbot commented Oct 22, 2015

From: Bot.io (Linux)

Received

pdfjsbot commented Oct 22, 2015

From: Bot.io (Linux)

Success

Published

Snuffleupagus Oct 22, 2015

Choose a reason for hiding this comment

yurydelendik commented Oct 22, 2015

pdfjsbot commented Oct 22, 2015

From: Bot.io (Windows)

Received

pdfjsbot commented Oct 22, 2015

From: Bot.io (Linux)

Received

pdfjsbot commented Oct 22, 2015

From: Bot.io (Windows)

Failed

pdfjsbot commented Oct 22, 2015

From: Bot.io (Linux)

Failed

yurydelendik commented Oct 22, 2015

yurydelendik commented Oct 23, 2015

timvandermeij commented Oct 24, 2015

yurydelendik commented Oct 24, 2015

Snuffleupagus commented Oct 24, 2015

yurydelendik commented Oct 24, 2015

brendandahl commented Oct 28, 2015

yurydelendik commented Oct 28, 2015

yurydelendik commented Oct 28, 2015

pdfjsbot commented Oct 28, 2015

From: Bot.io (Windows)

Received

pdfjsbot commented Oct 28, 2015

From: Bot.io (Windows)

Success

Published

timvandermeij commented Oct 29, 2015

pdfjsbot commented Oct 30, 2015

From: Bot.io (Windows)

Failed

pdfjsbot commented Oct 30, 2015

From: Bot.io (Linux)

Failed

brendandahl commented Oct 30, 2015

yurydelendik commented Nov 16, 2015

pdfjsbot commented Nov 16, 2015

From: Bot.io (Windows)

Received

pdfjsbot commented Nov 16, 2015

From: Bot.io (Linux)

Received

pdfjsbot commented Nov 16, 2015

From: Bot.io (Windows)

Failed

pdfjsbot commented Nov 16, 2015

From: Bot.io (Linux)

Failed

brendandahl commented Nov 18, 2015

pdfjsbot commented Nov 18, 2015

From: Bot.io (Linux)

Received

pdfjsbot commented Nov 18, 2015

From: Bot.io (Windows)

Received

brendandahl commented Nov 18, 2015

pdfjsbot commented Nov 18, 2015

From: Bot.io (Windows)

Success

pdfjsbot commented Nov 18, 2015

From: Bot.io (Linux)

Success