Try to remove the mozOpaque canvas-property (PR 6551 follow-up)
#14894
Conversation
According to MDN, see https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/mozOpaque, the `mozOpaque` canvas-property is not only non-standard (obviously) but it's also been deprecated. Instead it's recommended to use `alpha = false` when getting the canvas-context, see https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext#contextattributes, which all of our affected code is already doing.
|
Hopefully this won't break anything, since #6551 (comment) mentioned issues in Firefox on MacOS. However, that's over six years ago and it's hopefully no longer an issue now. |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d7df104234c8d6d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/10a0929a5b13f98/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d7df104234c8d6d/output.txt Total script time: 26.73 mins
Image differences available at: http://54.241.84.105:8877/d7df104234c8d6d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/10a0929a5b13f98/output.txt Total script time: 31.39 mins
Image differences available at: http://54.193.163.58:8877/10a0929a5b13f98/reftest-analyzer.html#web=eq.log |
|
Looks good to me; nice find! |
According to MDN, see https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/mozOpaque, the
mozOpaquecanvas-property is not only non-standard (obviously) but it's also been deprecated.Instead it's recommended to use
alpha = falsewhen getting the canvas-context, see https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext#contextattributes, which all of our affected code is already doing.