Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.3 #6653

Merged
merged 1 commit into from
Nov 19, 2015
Merged

Version 1.3 #6653

merged 1 commit into from
Nov 19, 2015

Conversation

yurydelendik
Copy link
Contributor

Due to #6551

@timvandermeij
Copy link
Contributor

Looks good to me. After all the recent PRs, I think there is enough reason to bump the version number (also because there have been more API changes).

@@ -1,6 +1,6 @@
{
"betaVersion": "1.2.109",
"stableVersion": "1.1.469",
"baseVersion": "2096a2a94a1f4971a15317bd75d4ec08c7f78f7f",
"versionPrefix": "1.2."
"baseVersion": "194994a2898a6d01c434d6d3270357799f3ac820",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to update this to point to commit 467c6f9 instead, since that fixes a regression from PR #6551?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version shall start at the moment we break API. Since we did not release 1.3 yet it's okay to provide fixes and improvements for 1.3 changes.

brendandahl added a commit that referenced this pull request Nov 19, 2015
@brendandahl brendandahl merged commit 1250e35 into mozilla:master Nov 19, 2015
@yurydelendik yurydelendik deleted the version1.3 branch January 28, 2016 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants