Update universal CSS for legacy IE browsers (Fixes #7390) #7502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
added
P2
alexgibson
force-pushed
the
universal-css
branch
from
94af7a1 to
1fafff6
Compare
|
Screenshots: Homepage before & after:
/firefox before & after
/accounts before & after
/channel before & after
|
alexgibson
force-pushed
the
universal-css
branch
from
1fafff6 to
2461db9
Compare
alexgibson
force-pushed
the
universal-css
branch
from
2461db9 to
15aaf00
Compare
stephaniehobson
approved these changes
Aug 1, 2019
| @@ -56,7 +56,7 @@ <h1 class="c-accounts-hero-title">{{ _('There is a way to protect your privacy. | |||
| </div> | |||
|
|
|||
| {% if has_signed_in_copy %} | |||
| <div class="c-accounts-hero-body c-accounts-hero-body-signed-in"> | |||
| <div class="c-accounts-hero-body c-accounts-hero-body-signed-in is-js-dependent"> | |||
There was a problem hiding this comment.
This only displays to signed in Firefox users so I'm not sure we need to hide it explicitly from IE.
There was a problem hiding this comment.
Old IE doesn’t load the CSS or JS that gets used to hide/show this piece of content, hence why the class here is needed.
| } | ||
|
|
||
| /* oldIE never gets slide out drawer */ | ||
| .moz-global-nav { |
There was a problem hiding this comment.
There's a few old CSS files we can remove this class from. I am writing this comment to remind myself to open an issue.
| @@ -55,8 +45,16 @@ label { | |||
| @include hidden; | |||
| } | |||
|
|
|||
| // Make sure form details are visible | |||
| .is-js-dependent { | |||
| display: none; | |||
|
Vast improvement from a menu perspective 💯 And the new |
|
Thanks for the review @stephaniehobson, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue / Bugzilla link
#7390
Testing