-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update universal CSS for legacy IE browsers (Fixes #7390) #7502
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,154 @@ | ||
// This Source Code Form is subject to the terms of the Mozilla Public | ||
// License, v. 2.0. If a copy of the MPL was not distributed with this | ||
// file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
||
$font-path: '/media/fonts'; | ||
$image-path: '/media/protocol/img'; | ||
|
||
@import '../../../protocol/css/includes/lib'; | ||
|
||
/* -------------------------------------------------------------------------- */ | ||
// Navigation styles | ||
|
||
.top-header-navigation { | ||
background: $color-white; | ||
color: $color-black; | ||
margin-bottom: $layout-lg; | ||
|
||
.mzp-c-navigation-l-content { | ||
padding: $layout-xs; | ||
} | ||
|
||
.mzp-c-navigation-container { | ||
@include clearfix; | ||
margin: 0 auto; | ||
max-width: $content-max; | ||
position: relative; | ||
} | ||
|
||
// Mozilla Logo | ||
.mzp-c-navigation-logo { | ||
left: 0; | ||
position: absolute; | ||
top: 0; | ||
width: 112px; | ||
|
||
a { | ||
@include image-replaced; | ||
background-image: url('/media/img/nav/logo-black.png'); | ||
background-repeat: no-repeat; | ||
display: block; | ||
height: 32px; | ||
margin: 0 auto; | ||
width: 112px; | ||
} | ||
} | ||
|
||
// Download button | ||
.mzp-c-navigation-download { | ||
display: inline-block; | ||
*display: inline; | ||
margin: 0; | ||
position: absolute; | ||
right: 0; | ||
text-align: center; | ||
top: 0; | ||
zoom: 1; | ||
|
||
.mzp-c-button-download-container { | ||
display: inline-block; | ||
*display: inline; | ||
margin-bottom: 0; | ||
zoom: 1; | ||
|
||
// hide privacy link | ||
.mzp-c-button-download-privacy-link { | ||
display: none; | ||
} | ||
} | ||
|
||
// hide FxA button | ||
.c-navigation-fxa-cta-container { | ||
display: none; | ||
} | ||
} | ||
|
||
// Nav buttom | ||
.mzp-c-navigation-menu-button { | ||
@include image-replaced; | ||
background-color: transparent; | ||
background-image: url('/media/img/nav/menu.png'); | ||
background-position-x: center; | ||
background-position-y: center; | ||
background-repeat: no-repeat; | ||
border-radius: 4px; | ||
border: none; | ||
display: none; | ||
height: 32px; | ||
left: 120px; | ||
padding: 1px 2px; | ||
position: absolute; | ||
top: 0; | ||
width: 28px; | ||
|
||
&:hover, | ||
&:active, | ||
&:focus, | ||
&.mzp-is-active { | ||
background-color: $color-gray-20; | ||
} | ||
} | ||
|
||
.mzp-c-navigation-items { | ||
margin-top: $layout-xs; | ||
} | ||
|
||
// hide panel close buttons | ||
.mzp-c-menu-button-close { | ||
display: none; | ||
} | ||
|
||
.mzp-c-menu-title { | ||
display: inline-block; | ||
*display: inline; | ||
font-weight: bold; | ||
margin-bottom: $spacing-xl; | ||
zoom: 1; | ||
} | ||
|
||
.mzp-c-menu-category { | ||
margin-bottom: $spacing-2xl; | ||
} | ||
|
||
// hide cards | ||
.mzp-c-menu-panel-card { | ||
display: none; | ||
} | ||
|
||
.mzp-c-navigation-menu { | ||
display: none; | ||
position: relative; | ||
top: $layout-lg; | ||
|
||
ul { | ||
list-style-type: none; | ||
margin: 0 0 $spacing-lg; | ||
padding: 0; | ||
|
||
li { | ||
margin: 0; | ||
padding: 0; | ||
} | ||
} | ||
|
||
.mzp-c-menu-panel { | ||
padding-left: $spacing-xl; | ||
} | ||
} | ||
} | ||
|
||
.js .top-header-navigation { | ||
.mzp-c-navigation-menu-button { | ||
display: block; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,10 +5,15 @@ | |
// This style sheet is served exclusively to Internet Explorer 8 and older. | ||
// Old versions get this minimal style while IE9 and up recieve more advanced styling. | ||
|
||
$font-path: '/media/fonts'; | ||
$image-path: '/media/protocol/img'; | ||
|
||
@import '../../protocol/css/includes/lib'; | ||
@import '../../protocol/css/base/elements'; | ||
@import '../../protocol/css/components/button'; | ||
|
||
@import 'components/navigation-ie'; | ||
@import 'components/navigation'; | ||
@import 'components/download-button'; | ||
|
||
// An arbitrary container for translatable strings to use in scripts | ||
|
@@ -32,21 +37,6 @@ label { | |
display: block; | ||
} | ||
|
||
.masthead .toggle { | ||
display: none; /* oldIE never gets a mobile menu. */ | ||
} | ||
|
||
/* oldIE never gets slide out drawer */ | ||
.moz-global-nav { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a few old CSS files we can remove this class from. I am writing this comment to remind myself to open an issue. |
||
.nav-button-menu { | ||
display: none; | ||
} | ||
} | ||
|
||
.moz-global-nav-drawer { | ||
display: none; | ||
} | ||
|
||
.visually-hidden { | ||
@include visually-hidden; | ||
} | ||
|
@@ -55,8 +45,16 @@ label { | |
@include hidden; | ||
} | ||
|
||
// Make sure form details are visible | ||
.is-js-dependent { | ||
display: none; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔥 |
||
} | ||
|
||
/* Make sure form details are visible */ | ||
/* stylelint-disable declaration-no-important */ | ||
.js .mzp-c-newsletter-details { | ||
display: block !important; | ||
} | ||
|
||
.mzp-c-newsletter-thanks { | ||
display: none; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only displays to signed in Firefox users so I'm not sure we need to hide it explicitly from IE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old IE doesn’t load the CSS or JS that gets used to hide/show this piece of content, hence why the class here is needed.