Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve universal stylesheet served to old IE browsers #7390

Closed
1 of 2 tasks
alexgibson opened this issue Jul 8, 2019 · 3 comments
Closed
1 of 2 tasks

Improve universal stylesheet served to old IE browsers #7390

alexgibson opened this issue Jul 8, 2019 · 3 comments
Assignees
Labels
P2 Second level priority - Should have Papercuts 💸 Tech debt payoff

Comments

@alexgibson
Copy link
Member

alexgibson commented Jul 8, 2019

Description

The universal stylesheet we serve to IE8 and below could benefit from some minor tweaks to make it a bit more readable:

Screenshot 2019-07-08 at 14 11 07

  1. The navigation contains many links, which pushes the main page content down a long way. We could provide a really basic layout for this so that it doesn't take up so much height.
  2. Hide the useless <button> elements (e.g. "Menu", "Close Firefox Menu"), that don't do anything without the JS.
  3. Improve readability by placing all content within a centered container in the page and a set max-width.
  4. Hide content that is only really meant for Firefox users.
  5. Anything else?

💛 Success Criteria 💛

  • Browsing the no-frills site is a slightly more pleasant experience.

Tasks

  • Update legacy IE stylesheets.
@alexgibson alexgibson modified the milestone: Technical Roadmap Q4 2019 Jul 8, 2019
@hoosteeno
Copy link
Contributor

@alexgibson do we know enough about this to estimate the effort of it?

@alexgibson
Copy link
Member Author

alexgibson commented Jul 15, 2019

@hoosteeno probably a days work, possibly a 3 (Assuming this is just an engineering task. If we want design input then this could grow).

@ejregithub ejregithub added this to the S2/Q3: 20190722-20190809 milestone Jul 17, 2019
@alexgibson alexgibson self-assigned this Jul 29, 2019
@hoosteeno hoosteeno added the P2 Second level priority - Should have label Jul 30, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue Jul 31, 2019
@alexgibson
Copy link
Member Author

This is now up on demo at: https://bedrock-demo-agibson.oregon-b.moz.works/

Screenshots for those without VMs:

Homepage before & after:

homepage-ie

/firefox before & after

firefox-ie

/accounts before & after

accounts-ie

/channel before & after

channel-ie

alexgibson added a commit to alexgibson/bedrock that referenced this issue Jul 31, 2019
@alexgibson alexgibson added the Needs Review Awaiting code review label Jul 31, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue Jul 31, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue Aug 1, 2019
@stephaniehobson stephaniehobson removed the Needs Review Awaiting code review label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Second level priority - Should have Papercuts 💸 Tech debt payoff
Projects
None yet
Development

No branches or pull requests

4 participants