-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradle builds for Apple Silicon running arm64 JDKs #4792
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4792 +/- ##
=======================================
Coverage 81.53% 81.53%
=======================================
Files 49 49
Lines 5650 5650
=======================================
Hits 4607 4607
Misses 1043 1043 Continue to review full report at Codecov.
|
@tarikeshaq would you mind following the instructions to test that this works on Intel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it on my Intel machine! app services builds all the way across the local development flow to fenix/android components. As we debugged yesterday, I had a rust.targets
in my local.properties
and I need to replace darwin
with darwin-x86-64
.
We should probably the docs in https://github.com/mozilla/application-services/blob/main/docs/howtos/locally-published-components-in-fenix.md to reference the new darwin-x86-64
and darwin-aarch64
targets instead of darwin
This is blocked until:
land as any M1s hoping to build a-s and then use the locally published flow in a-c will run into issues with the kotlin library |
cc3d6e8
to
298888f
Compare
While this fixes it in a-s, there will be an issue in a-c with the |
298888f
to
8721e2c
Compare
fixes #4665
To Test (Intel or M1 Mac)
rust.targets
in yourlocal.properties
update (or just comment out for now):darwin
targets./libs/verify-desktop-environment.sh
./build-all.sh android
(shouldn't need rebuild but just incase)./gradlew assembleDebug
Pull Request checklist
[ci full]
to the PR title.