-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable downloading native libs in android [ci full] #4846
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4846 +/- ##
=======================================
Coverage 38.42% 38.42%
=======================================
Files 166 166
Lines 12343 12343
=======================================
Hits 4743 4743
Misses 7600 7600 Continue to review full report at Codecov.
|
Nice catch! I thought cross-compile-target was CI. So technically application-services/libs/build-nss-desktop.sh Lines 30 to 32 in cbfa39d
application-services/libs/build-sqlcipher-desktop.sh Lines 29 to 31 in cbfa39d
|
Came across this again trying to build app services on android - I'll land this for now, if I notice this breaking for anyone's local environment (it shouldn't, but 🤷) I'll revert it |
Disable downloading native libraries, forcing local environments to build the native libraries (nss, etc) themselves.
This is because for macs, the
useDownloadedLibs
flow is broken, since after #4792NSS_DIR
is expected to be point to adarwin-x86-64
ordarwin-aarch64
when the downloaded libraries always have them in adarwin
directory.The alternative is to force set the
NSS_DIR
to point todarwin
in gradle, but that won't work for M1s, since the downloaded libs don't have M1 builds anyways