This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grigoryk
requested review from
Amejia481,
csadilek,
gabrielluong,
jonalmeida,
pocmo,
rocketsroger and
a team
as code owners
January 11, 2022 01:02
4 tasks
Was hoping for a final release of the Compose upgrade, but we got an RC03 instead. |
6 tasks
Stable release is out! 🎉 |
grigoryk
force-pushed
the
kotlin16
branch
2 times, most recently
from
February 15, 2022 02:49
be46e1b
to
d2a5f38
Compare
3 tasks
Fenix side of this work: mozilla-mobile/fenix#23736 |
As a result of this refactor, we get exhaustive 'when' statements when dealing with placement information.
4 tasks
This pull request has conflicts when rebasing. Could you fix it @grigoryk? 🙏 |
Just adding a note that this is blocked on finding the cause of mozilla-mobile/fenix#23989 which was triggered by the (since reverted) upgrade of compose to 1.1.0. |
This pull request has conflicts when rebasing. Could you fix it @grigoryk? 🙏 |
Will work on adding this on top of #12000 and continue with what's left. |
This will be completed in #12006. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working through the tests (see https://github.com/Kotlin/kotlinx.coroutines/blob/master/kotlinx-coroutines-test/MIGRATION.md)
Pull Request checklist
After merge