Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-5293: Add missing a11y names in "Contact Support" screen #8623

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

vinocher
Copy link
Contributor

@vinocher vinocher commented Nov 23, 2023

Description

"Contact Support" screen's ComboBox and "Describe Issue" TextArea did not have a11y names, so were not read by the screen reader.

Also fixed:

  1. Shift+Tab in the "Describe Issue" TextArea was being input into the TextArea instead of moving to the previous control.
  2. Subtitle in Home screen was not accessible.

Reference

VPN-5293, GitHub 7631

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@vinocher vinocher self-assigned this Nov 23, 2023
@vinocher vinocher changed the title VPN-5293: Add missing a11y name in "Contact Support" screen VPN-5293: Add missing a11y names in "Contact Support" screen Nov 23, 2023
@vinocher vinocher force-pushed the vinocher/contactA11y branch from cbc6775 to 1792b2c Compare November 29, 2023 18:54
Copy link
Member

@lesleyjanenorton lesleyjanenorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ with one question. Thanks @vinocher !

@vinocher vinocher merged commit b526ff0 into main Nov 29, 2023
121 checks passed
@vinocher vinocher deleted the vinocher/contactA11y branch November 29, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants