Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-5293: Add missing a11y names in "Contact Support" screen #8623

Merged
merged 2 commits into from
Nov 29, 2023
Merged

VPN-5293: Add missing a11y names in "Contact Support" screen #8623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afd088d
Add missing a11y name in Contact screen
vinocher Nov 23, 2023
1792b2c
Subtitle in Home screen was not being read
vinocher Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nebula/ui/components/forms/MZComboBox.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import compat 0.1
import components 0.1

ComboBox {
property string placeholderText
property string placeholderText: ""
property bool showInteractionStates: true
textRole: "name"
valueRole: "value"
Expand All @@ -20,6 +20,7 @@ ComboBox {
Layout.preferredHeight: MZTheme.theme.rowHeight
currentIndex: -1
activeFocusOnTab: true
Accessible.name: contentItem.text
background: MZInputBackground {
z: -1
}
Expand Down
3 changes: 3 additions & 0 deletions nebula/ui/components/forms/MZTextArea.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ Item {
id: textArea

Accessible.focused: textArea.focus
Accessible.name: formattedPlaceholderText.visible ? formattedPlaceholderText.text : textArea.text
background: MZInputBackground {
itemToFocus: textArea
z: -1
Expand All @@ -68,6 +69,8 @@ Item {
wrapMode: Text.WrapAtWordBoundaryOrAnywhere

Keys.onTabPressed: nextItemInFocusChain().forceActiveFocus(Qt.TabFocusReason)
Keys.onBacktabPressed: nextItemInFocusChain(false).forceActiveFocus(Qt.BacktabFocusReason)

onTextChanged: {
handleOnTextChanged(textArea.text);

Expand Down
2 changes: 0 additions & 2 deletions src/ui/screens/home/controller/ControllerView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,6 @@ Item {
lineHeight: 22
font.pixelSize: 22
Accessible.ignored: connectionInfoScreenVisible || ipInfoPanel.isOpen || !visible
Accessible.description: logoSubtitle.text
width: parent.width
onPaintedHeightChanged: if (visible) col.handleMultilineText()
onTextChanged: handleConnectionStateChange()
Expand All @@ -635,7 +634,6 @@ Item {
objectName: "controllerSubTitle"

lineHeight: MZTheme.theme.controllerInterLineHeight
Accessible.ignored: true
lesleyjanenorton marked this conversation as resolved.
Show resolved Hide resolved
width: parent.width - MZTheme.theme.windowMargin
anchors.horizontalCenter: parent.horizontalCenter
onPaintedHeightChanged: if (visible) col.handleMultilineText()
Expand Down
Loading