VPN-5293: Add missing a11y names in "Contact Support" screen (#8623)

* Add missing a11y name in Contact screen * Subtitle in Home screen was not being read
mozilla-mobile · Nov 29, 2023 · b526ff0 · b526ff0
1 parent 820f344
commit b526ff0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/nebula/ui/components/forms/MZComboBox.qml b/nebula/ui/components/forms/MZComboBox.qml
@@ -11,7 +11,7 @@ import compat 0.1
 import components 0.1
 
 ComboBox {
-    property string placeholderText
+    property string placeholderText: ""
     property bool showInteractionStates: true
     textRole: "name"
     valueRole: "value"
@@ -20,6 +20,7 @@ ComboBox {
     Layout.preferredHeight: MZTheme.theme.rowHeight
     currentIndex: -1
     activeFocusOnTab: true
+    Accessible.name: contentItem.text
     background: MZInputBackground {
         z: -1
     }

diff --git a/nebula/ui/components/forms/MZTextArea.qml b/nebula/ui/components/forms/MZTextArea.qml
@@ -47,6 +47,7 @@ Item {
             id: textArea
 
             Accessible.focused: textArea.focus
+            Accessible.name: formattedPlaceholderText.visible ? formattedPlaceholderText.text : textArea.text
             background: MZInputBackground {
                 itemToFocus: textArea
                 z: -1
@@ -68,6 +69,8 @@ Item {
             wrapMode: Text.WrapAtWordBoundaryOrAnywhere
 
             Keys.onTabPressed: nextItemInFocusChain().forceActiveFocus(Qt.TabFocusReason)
+            Keys.onBacktabPressed: nextItemInFocusChain(false).forceActiveFocus(Qt.BacktabFocusReason)
+
             onTextChanged: {
                 handleOnTextChanged(textArea.text);
 

diff --git a/src/ui/screens/home/controller/ControllerView.qml b/src/ui/screens/home/controller/ControllerView.qml
@@ -619,7 +619,6 @@ Item {
             lineHeight: 22
             font.pixelSize: 22
             Accessible.ignored: connectionInfoScreenVisible || ipInfoPanel.isOpen || !visible
-            Accessible.description: logoSubtitle.text
             width: parent.width
             onPaintedHeightChanged: if (visible) col.handleMultilineText()
             onTextChanged: handleConnectionStateChange()
@@ -635,7 +634,6 @@ Item {
             objectName: "controllerSubTitle"
 
             lineHeight: MZTheme.theme.controllerInterLineHeight
-            Accessible.ignored: true
             width: parent.width - MZTheme.theme.windowMargin
             anchors.horizontalCenter: parent.horizontalCenter
             onPaintedHeightChanged: if (visible) col.handleMultilineText()