-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MTC to concepts #809
Add MTC to concepts #809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Found a few typos and inconsistencies, but it looks great.
One suggestion, if you want, is that because there's so many class names thrown around, to highlight them using CodeFont
or Bold or something in the text.
doc/concepts/moveit_task_constructor/moveit_task_constructor.rst
Outdated
Show resolved
Hide resolved
I would prefer if you would augment the existing MTC documentation here instead of starting a new one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I propose to update the original MTC docs instead of starting/maintaining a second set of MTC docs here!
Yep, I will do that today. Just organizing my thoughts here and addressing some reviews before I open a PR to MTC. |
2b10c6d
to
190fb71
Compare
doc/concepts/moveit_task_constructor/moveit_task_constructor.rst
Outdated
Show resolved
Hide resolved
doc/concepts/moveit_task_constructor/moveit_task_constructor.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
Co-authored-by: Sebastian Castro <[email protected]>
fac23f6
to
5b7141b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Abishalini!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks Abi! Left a few grammer/style comments, and a few questions from the perspective of someone who doesn't have much experience with MTC.
doc/concepts/moveit_task_constructor/moveit_task_constructor.rst
Outdated
Show resolved
Hide resolved
state.setToDefaultValues(state.getJointModelGroup("left_arm"), "home"); | ||
state.setToDefaultValues(state.getJointModelGroup("right_arm"), "home"); | ||
state.update(); | ||
spawnObject(scene); // Add a CollisionObject to planning scene |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a user-defined function? If so, it'd be worth clarifying this so that readers don't try to call spawnObject
without implementing it and then wonder why they're getting errors 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the comment
doc/concepts/moveit_task_constructor/moveit_task_constructor.rst
Outdated
Show resolved
Hide resolved
doc/concepts/moveit_task_constructor/moveit_task_constructor.rst
Outdated
Show resolved
Hide resolved
doc/concepts/moveit_task_constructor/moveit_task_constructor.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Ashton Larkin <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
MTC does not have a lot of docs and here is an attempt to make MTC easier to get started with.
This doc will go over what is an MTC task and the different kinds of stages and containers that can be added to an MTC task (with code examples).
I also want to add a detailed section on how to debug MTC tasks and MTC stage solutions.