Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.4.1 - patching release date and version #243

Merged
merged 11 commits into from
Feb 28, 2019
Merged

release 0.4.1 - patching release date and version #243

merged 11 commits into from
Feb 28, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Feb 28, 2019

chfw added 11 commits February 24, 2019 19:38
* ✨ port minimum requirement test via pypi-mobans from pyexcel. #187

* 🐛 fix travis ci file

* 🐛 update unit tests

* :wheel_chair: lower the dependencies
* 🔨 code refactoring

* 💄 reformat code
* 🔨 code refactoring

* 💄 reformat code

* 🔥 remove MobanEngine's reference to the engine class

* 🔨 refactoring the code and un-bury engine instance

* ✨ initial prototype, not tested. #235

* 📚 fix doc build

* 🐛 fix docs build

* 🔨 refactoring. user define template takes precedence

* 🔬 test user define engine

* ✨ associate user defined file extensions with user defined template engine name, i.e. custom_jinja for jinja2, custom_handlebars for handlebars, #235

* ✨ take template types from moban file. related to #233

* 🔨 address the feedback

* 🐛 fix typos and add line feed

* 💄 beautify the code
@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #243 into master will increase coverage by 0.03%.
The diff coverage is 98.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage    99.3%   99.33%   +0.03%     
==========================================
  Files          57       57              
  Lines        2287     2402     +115     
==========================================
+ Hits         2271     2386     +115     
  Misses         16       16
Impacted Files Coverage Δ
moban/mobanfile/__init__.py 99.24% <100%> (+0.02%) ⬆️
moban/_version.py 100% <100%> (ø) ⬆️
tests/mobanfile/test_mobanfile.py 100% <100%> (ø) ⬆️
...sts/integration_tests/test_command_line_options.py 100% <100%> (ø) ⬆️
tests/test_engine.py 100% <100%> (ø) ⬆️
tests/mobanfile/test_templates.py 100% <100%> (ø) ⬆️
moban/jinja2/engine.py 100% <100%> (ø) ⬆️
moban/repo.py 100% <100%> (ø) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️
tests/test_template.py 100% <100%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878c418...00b6c77. Read the comment docs.

@chfw chfw merged commit 4159e0f into master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants