Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate lower dependencies #187

Closed
jayvdb opened this issue Jan 28, 2019 · 3 comments
Closed

Investigate lower dependencies #187

jayvdb opened this issue Jan 28, 2019 · 3 comments
Milestone
0.4.0

Comments

@jayvdb
Copy link
Member

jayvdb commented Jan 28, 2019

We should have an explicitly stated reason for each dependency minimum version, so users/packagers know that it is not arbitrary.

And have a CI job which uses the minimum version, to avoid any bugs with specific minimum versions.

And ideally also have a job which uses random versions between minimum and most recent, to flush out any bugs with specific versions.

@pyexcel had a job with minimum version, and maybe had random versions also.
@jayvdb jayvdb pinned this issue Jan 28, 2019
@chfw
Copy link
Member

chfw commented Jan 28, 2019

GitPython
RueYaml
appdirs

@jayvdb
Copy link
Member Author

jayvdb commented Jan 29, 2019

This may involve moving some pyexcel CI into pypi-mobans.

@jayvdb jayvdb added this to the 0.4.0 milestone Jan 30, 2019
@jayvdb jayvdb mentioned this issue Feb 7, 2019
Open
@chfw
Copy link
Member

chfw commented Feb 17, 2019

will progress after this PR is merged: moremoban/pypi-mobans#74

chfw added a commit that referenced this issue Feb 24, 2019
@chfw
✨ port minimum requirement test via pypi-mobans from pyexcel. #187
f4f1c07
@chfw chfw mentioned this issue Feb 24, 2019
Merged
chfw added a commit that referenced this issue Feb 24, 2019
@chfw
Lower dependencies (#232)
b9df5cd 
* ✨ port minimum requirement test via pypi-mobans from pyexcel. #187

* 🐛 fix travis ci file

* 🐛 update unit tests

* :wheel_chair: lower the dependencies
@chfw chfw closed this as completed Feb 24, 2019
@chfw chfw unpinned this issue Feb 26, 2019
chfw added a commit that referenced this issue Feb 28, 2019
@chfw
release 0.4.1 (#241)
217608f 
* Lower dependencies (#232)

* ✨ port minimum requirement test via pypi-mobans from pyexcel. #187

* 🐛 fix travis ci file

* 🐛 update unit tests

* :wheel_chair: lower the dependencies

* 💄 pump up the version number

* Minor code refactoring (#236)

* 🔨 code refactoring

* 💄 reformat code

* 📚 fix doc build

* 🐛 fix docs build

* Initial prototype for 202 template types (#239)

* 🔨 code refactoring

* 💄 reformat code

* 🔥 remove MobanEngine's reference to the engine class

* 🔨 refactoring the code and un-bury engine instance

* ✨ initial prototype, not tested. #235

* 📚 fix doc build

* 🐛 fix docs build

* 🔨 refactoring. user define template takes precedence

* 🔬 test user define engine

* ✨ associate user defined file extensions with user defined template engine name, i.e. custom_jinja for jinja2, custom_handlebars for handlebars, #235

* ✨ take template types from moban file. related to #233

* 🔨 address the feedback

* 🐛 fix typos and add line feed

* 💄 beautify the code

* 📚 provide documentation on template_types under configuration. fix #237 (#240)

* 📚 update change log.#232, #235

* 💄 address review feedback
ayan-b pushed a commit to ayan-b/moban that referenced this issue Apr 21, 2019
@chfw @ayan-b
Lower dependencies (moremoban#232)
2cec0ba 
* ✨ port minimum requirement test via pypi-mobans from pyexcel. moremoban#187

* 🐛 fix travis ci file

* 🐛 update unit tests

* :wheel_chair: lower the dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@jayvdb @chfw