release 0.4.1 #241
Merged
release 0.4.1 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ✨ port minimum requirement test via pypi-mobans from pyexcel. #187 * 🐛 fix travis ci file * 🐛 update unit tests * :wheel_chair: lower the dependencies
* 🔨 code refactoring * 💄 reformat code
* 🔨 code refactoring * 💄 reformat code * 🔥 remove MobanEngine's reference to the engine class * 🔨 refactoring the code and un-bury engine instance * ✨ initial prototype, not tested. #235 * 📚 fix doc build * 🐛 fix docs build * 🔨 refactoring. user define template takes precedence * 🔬 test user define engine * ✨ associate user defined file extensions with user defined template engine name, i.e. custom_jinja for jinja2, custom_handlebars for handlebars, #235 * ✨ take template types from moban file. related to #233 * 🔨 address the feedback * 🐛 fix typos and add line feed * 💄 beautify the code
chfw
requested review from
ayan-b,
jayvdb,
CLiu13,
PrajwalM2212 and
seeeturtle
|
"release early and release often" |
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 99.3% 99.33% +0.03%
==========================================
Files 57 57
Lines 2287 2402 +115
==========================================
+ Hits 2271 2386 +115
Misses 16 16
Continue to review full report at Codecov.
|
ayan-b
reviewed
Feb 28, 2019
docs/level-18-user-defined-template-types/.moban.cd/data.base.yaml
Outdated
Show resolved
Hide resolved
ayan-b
reviewed
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deliver #235, #232.
#234 could come in later versions of 0.4.x when it will be ready.