CLOUDP-231153: Do not test backups on an M0 #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jose.vazquez <[email protected]>
s-urbaniak
approved these changes
Feb 23, 2024
s-urbaniak
reviewed
Feb 23, 2024
This reverts commit 6d22448. Signed-off-by: jose.vazquez <[email protected]>
josvazg
force-pushed
the
CLOUDP-231153/fix-helm-ns-m0-test
branch
from
cc7f740 to
d73933a
Compare
s-urbaniak
approved these changes
Feb 23, 2024
helderjs
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve test reliability by expecting any progress on generations.
This issue was introduced by #1182
In concrete the M10 instance was changed to an M0 which does not allow for backups:
https://github.com/mongodb/mongodb-atlas-kubernetes/pull/1182/files#diff-0269841ec7d5fd9935fb6088f4f2aa50fda6052321278541ce5b5ad669bb513bL11
The failure might not have been seen before due to this other change that might have made experience flaky behaviour:
https://github.com/mongodb/mongodb-atlas-kubernetes/pull/1182/files#diff-fae195fa8f187a7dc9d0d23e2779416cb565f061c183ebf8f501f53fa4477303L32
Changing the expected generation.
We should also follow up on relying on generations on tests, we should probably avoid it.
Tests
✅ helm-ns passed first time it actually run
All Submissions: