Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-231153: Do not test backups on an M0 #1395

Merged
merged 3 commits into from
Feb 23, 2024
Merged

CLOUDP-231153: Do not test backups on an M0 #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4af7a52
CLOUDP-231153: Do not test backups on an M0
josvazg Feb 22, 2024
6d22448
add traces
josvazg Feb 22, 2024
d73933a
Revert "add traces"
josvazg Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/helper/e2e/actions/steps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ func WaitDeployment(data *model.TestDataProvider, generation int) {
g.Expect(err).ToNot(HaveOccurred())
return gen
},
).WithTimeout(5 * time.Minute).WithPolling(10 * time.Second).Should(Equal(generation))
// Waiting for a particular generation can be brittle, to make it more robust
// wait for any progress to or beyond the expected generation
).WithTimeout(5 * time.Minute).WithPolling(10 * time.Second).Should(BeNumerically(">=", generation))
s-urbaniak marked this conversation as resolved.
Show resolved Hide resolved

WaitDeploymentWithoutGenerationCheck(data)
}
Expand All @@ -48,7 +50,9 @@ func WaitDeployment(data *model.TestDataProvider, generation int) {
g.Expect(err).ToNot(HaveOccurred())
return gen
},
).WithTimeout(5 * time.Minute).WithPolling(10 * time.Second).Should(Equal(generation))
// Waiting for a particular generation can be brittle, to make it more robust
// wait for any progress to or beyond the expected generation
).WithTimeout(5 * time.Minute).WithPolling(10 * time.Second).Should(BeNumerically(">=", generation))

WaitDeploymentWithoutGenerationCheckV2(data)
}
Expand Down
2 changes: 1 addition & 1 deletion test/helper/e2e/data/atlasdeployment_basic_helm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
- zoneName: Zone 1
regionConfigs:
- electableSpecs:
instanceSize: M0
instanceSize: M2
nodeCount: 1
providerName: TENANT
backingProviderName: "AWS"
Expand Down
Loading