CLOUDP-205482: Remove legacy deployment #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-karpukhin
force-pushed
the
CLOUDP-205482/remove-legacy-deployment
branch
2 times, most recently
from
a8b1b38 to
73120ed
Compare
igor-karpukhin
force-pushed
the
CLOUDP-205482/remove-legacy-deployment
branch
2 times, most recently
from
2d2767c to
c8ff524
Compare
igor-karpukhin
force-pushed
the
CLOUDP-205482/remove-legacy-deployment
branch
from
c8ff524 to
fb2b806
Compare
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
pkg/controller/atlasdeployment/atlasdeployment_controller_test.go
Outdated
Show resolved
Hide resolved
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
| @@ -86,14 +77,7 @@ func deploymentForGov(deployment *mdbv1.AtlasDeploymentSpec, regionUsageRestrict | |||
| var err error | |||
|
|
|||
| if deployment.DeploymentSpec != nil { | |||
| regionErr := validCloudGovRegion(regionUsageRestrictions, deployment.DeploymentSpec.ProviderSettings.RegionName) | |||
There was a problem hiding this comment.
not sure why this gov related check is no longer needed here, can you elaborate?
There was a problem hiding this comment.
Since there is no more legacy clusters, regions need to be validated for every replica set. See this method is called below.
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
| @@ -40,4 +40,4 @@ export MCLI_PUBLIC_API_KEY="${public_key}" | |||
| export MCLI_PRIVATE_API_KEY="${private_key}" | |||
| export MCLI_ORG_ID="${org_id}" | |||
| export IMAGE_URL="${image}" #for helm chart | |||
| AKO_E2E_TEST=1 ginkgo --label-filter="${focus_key}" --timeout 120m -v test/e2e/ | |||
| AKO_E2E_TEST=1 ginkgo --label-filter="${focus_key}" --timeout 120m -vv test/e2e/ | |||
There was a problem hiding this comment.
do we need this verbosity in the final version?
There was a problem hiding this comment.
This gives a better output for the errors. And this is only for the local usage as you can see
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
josvazg
reviewed
Oct 30, 2023
|
I suspect the helm update issue might not be transient? |
helderjs
requested changes
Oct 30, 2023
pkg/controller/atlasdeployment/atlasdeployment_controller_test.go
Outdated
Show resolved
Hide resolved
|
LGTM, waiting for testing to go green to approve |
helderjs
approved these changes
Nov 2, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
spec.advancedDeploymentSpecfrom theAtlasDeploymentresource.spec.deploymentSpecnow contains fields fromspec.advancedDeploymentSpecAll Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).