fix: make install-local script work, update react to 17 VSCODE-310

[Anemy]

VSCODE-310

• Updates react to 17 for leafygreen.
• Re-adds a workaround patch we use in our CI package script that we had removed from our local install packaging script.

Note

Before we merge this we'll need to update our mongodb-data-service dependency to pull in a new version of @mongodb-js/compass-utils so that the @electron/remote dependency isn't required. PR: mongodb-js/compass#4032. That will make the npm list command that vsce package runs stop failing so install-local starts working again. I manually tested that things work after that fix by doing some node_modules updates and package-lock changes locally. Opening as a draft for now.

Addresses #353

[Anemy]

Updating our mongodb-data-service dependency took a good amount of changes as it updated the api to use promises instead of callbacks. Added electron to dev deps to make the install script work as it appears npm list --production --parseable --depth=99999 --loglevel=error will fail on optional dependencies. Not sure if there's a way to work around that without including more monkey patches like the no-npm-list-fail.js was doing.

[Anemy]

Error: Command failed: npm list --production --parseable --depth=99999 --loglevel=error
npm ERR! code ELSPROBLEMS
npm ERR! invalid: [email protected] D:\a\vscode\vscode\node_modules\mongodb
npm ERR! invalid: [email protected] D:\a\vscode\vscode\node_modules\js-yaml

Not sure why these are showing up, looking into.

[Anemy]

Opening this up for review. I tried to remove the workaround the no-npm-list-fail.js was doing but wasn't able to for the ci. I think this is something to do with the install omitting optional dependencies:

vscode/.github/workflows/test-and-build.yaml

Line 57 in 750c17a

run: npm ci --omit=optional

When it runs that install the npm package list command run by vsce fails:
npm list --production --parseable --depth=99999 --loglevel=error
I don't know the exact reasoning why, I think it's something to do with transitive optional peer dependencies being hoisted differently. For now I'll keep things as. It does mean that the local-install script is susceptible to breaking again without the CI reporting it. Once we can remove the node workaround that silences npm list errors we'll have more confidence that the local install script works. I created a ticket to track that VSCODE-370. Regardless, folks should be able to run npm run local-install again and have it install the extension to their VSCode instance.

[alenakhineika]

This is interesting. My branch suddenly started failing on this test suite. I copied this refactored version to it and now tests pass. Hope you don't mind I copied it here: 8d77ef3#diff-a468a59574d19865f8eea5715e9ceaa187fb55debcddb46eee85c55236408c6d

[Anemy]

I just pushed up a new commit that removes usage of DataServiceImpl instead using only the DataService type. I think you'll want to update it again - sorry!

[alenakhineika]

It actually started to fail again with the old version I copied. Something weird is happening with this test suit.

[Anemy]

Not sure what's happening at a glance. Are the dependencies possible from a different branch? Maybe try and 'npm install'