-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: playgrounds in JS VSCODE-372 #482
Conversation
…guage # Conflicts: # package-lock.json
@alenakhineika Notes from a quick test:
|
@mmarcon absolutely agree it would be very useful! Created tickets: VSCODE-380 - Suggest |
src/test/suite/editors/activeConnectionCodeLensProvider.test.ts
Outdated
Show resolved
Hide resolved
src/test/suite/editors/playgroundSelectedCodeActionProvider.test.ts
Outdated
Show resolved
Hide resolved
src/test/suite/editors/playgroundSelectedCodeActionProvider.test.ts
Outdated
Show resolved
Hide resolved
…guage # Conflicts: # package-lock.json # package.json # src/test/suite/editors/activeDBCodeLensProvider.test.ts # src/test/suite/telemetry/connectionTelemetry.test.ts # src/test/suite/telemetry/telemetryService.test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, going to give this a try on local now, left a couple comments.
Description
Make playgrounds become proper JavaScript environments.
update-grammar
script to update the MongoDB injection grammar with the most recent DevTools constants during the build process.javascript
andplaintext
languages.isPlayground
util function that will identify playgrounds among other JavaScrip files.mongodb
language id and replace it withisPlayground
check.Checklist
Motivation and Context
Open Questions
Dependents
Types of changes