fix(compass-utils): update @electron/remote to optional dependency for vscode packaging VSCODE-310 #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
changed the title
Anemy
changed the title
alenakhineika
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-310
To make
npm run packagework in VSCode we need to make the packaging command run by the vscode extension manager (vsce)npm list --production --parseable --depth=99999 --loglevel=errorwork.One of the parts of this is to make
@electron/remotean optional dependency of@mongodb-js/compass-utils, so that it's not required for thenpm listcommand above.The error it is showing currently in packaging is:
npm ERR! missing: electron@>= 13.0.0, required by @electron/[email protected]There might be a way to indicate in our configuration not to require this dependency, however as this
@electron/remotedependency isn't always required in our code from what I understand I'm thinking this is how we probably want to handle it.We'll need to do a package release after this is bumped.