Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): build and test packaged app on the newer macos version COMPASS-8090 #6220

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

kraenhansen
Copy link
Contributor

Description

A friendly takeover of #5990 incorporating @mcasimir's feedback: #5990 (comment)

Updates the build variants used for packaging the app on MacOS to 14 and adds two new test variants for the MacOS 14. We might want to simply remove test-packaged-app-macos-11-arm and test-packaged-app-macos-11-x64 in the future.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen marked this pull request as ready for review September 11, 2024 07:33
Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And seems like the flake I was seeing in my branch gone away, neat!

@@ -71,7 +71,7 @@ buildvariants:
expansions:
silk_asset_group: compass-macos-arm
display_name: Package MacOS Arm64
run_on: macos-1100-arm64
run_on: macos-14-arm64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for context, we've been building on a fairly low macOS version because we've felt that it gives us a better sense of guarantee that Compass will actually run on the macOS versions we claim to support. Currently, in our docs, that's 10.12 – which is definitely wrong at this point, Electron 27 raised the minimum to 10.15, so I'd recommend closing this ticket with "Documentation Changes Needed".

Now, I've chatted with some people in devprod before, but haven't really found anyone who is intimately familiar with what macOS's actual forward/backward compatibility story looks like in practice – i.e. answers to questions like "if we package on macOS 14, can we still relatively safely claim that it will run on 10.15 (or on 11, etc.)? Does it even really matter?".

All of which is to say: I think this change is fine, but in the long run we'll probably want to figure out what the actual story here is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants