Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): build and test packaged app on the newer macos version COMPASS-8090 #6220

Merged
merged 1 commit into from
Sep 11, 2024
Merged

chore(ci): build and test packaged app on the newer macos version COMPASS-8090 #6220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions .evergreen/buildvariants-and-tasks.in.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,48 +49,61 @@ const PACKAGE_BUILD_VARIANTS = [
{
name: 'package-macos-x64',
display_name: 'Package MacOS Intel',
run_on: 'macos-1100',
run_on: 'macos-14',
silk_asset_group: 'compass-macos',
},
{
name: 'package-macos-arm',
display_name: 'Package MacOS Arm64',
run_on: 'macos-1100-arm64',
run_on: 'macos-14-arm64',
silk_asset_group: 'compass-macos-arm',
}
];

const TEST_PACKAGED_APP_BUILD_VARIANTS = [
{
name: 'test-server-ubuntu',
name: 'test-packaged-app-ubuntu',
display_name: 'Ubuntu 20.04',
run_on: 'ubuntu2004-large',
depends_on: 'package-ubuntu',
},
{
name: 'test-server-windows',
name: 'test-packaged-app-windows',
display_name: 'Windows 10',
run_on: 'windows-vsCurrent-large',
depends_on: 'package-windows',
},
{
name: 'test-server-rhel',
name: 'test-packaged-app-rhel',
display_name: 'RHEL 8.0',
run_on: 'rhel80-large',
depends_on: 'package-rhel',
},
{
name: 'test-server-macos-11-arm',
name: 'test-packaged-app-macos-11-arm',
display_name: 'MacOS arm64 11',
run_on: 'macos-1100-arm64-gui',
depends_on: 'package-macos-arm'
},
{
name: 'test-server-macos-11-x64',
name: 'test-packaged-app-macos-11-x64',
display_name: 'MacOS x64 11',
run_on: 'macos-1100-gui',
patchable: false,
depends_on: 'package-macos-x64'
},
{
name: 'test-packaged-app-macos-14-arm',
display_name: 'MacOS arm64 14',
run_on: 'macos-14-arm64-gui',
depends_on: 'package-macos-arm'
},
{
name: 'test-packaged-app-macos-14-x64',
display_name: 'MacOS x64 14',
run_on: 'macos-14-gui',
patchable: false,
depends_on: 'package-macos-x64'
}
];

Expand Down
36 changes: 29 additions & 7 deletions .evergreen/buildvariants-and-tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ buildvariants:
expansions:
silk_asset_group: compass-macos
display_name: Package MacOS Intel
run_on: macos-1100
run_on: macos-14
tasks:
- name: package-compass
- name: package-compass-isolated
Expand All @@ -71,7 +71,7 @@ buildvariants:
expansions:
silk_asset_group: compass-macos-arm
display_name: Package MacOS Arm64
run_on: macos-1100-arm64
run_on: macos-14-arm64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for context, we've been building on a fairly low macOS version because we've felt that it gives us a better sense of guarantee that Compass will actually run on the macOS versions we claim to support. Currently, in our docs, that's 10.12 – which is definitely wrong at this point, Electron 27 raised the minimum to 10.15, so I'd recommend closing this ticket with "Documentation Changes Needed".

Now, I've chatted with some people in devprod before, but haven't really found anyone who is intimately familiar with what macOS's actual forward/backward compatibility story looks like in practice – i.e. answers to questions like "if we package on macOS 14, can we still relatively safely claim that it will run on 10.15 (or on 11, etc.)? Does it even really matter?".

All of which is to say: I think this change is fine, but in the long run we'll probably want to figure out what the actual story here is.

tasks:
- name: package-compass
- name: package-compass-isolated
Expand Down Expand Up @@ -145,7 +145,7 @@ buildvariants:
- name: test-server-latest-alpha-1
- name: test-server-latest-alpha-2
- name: test-server-latest-alpha-3
- name: test-server-ubuntu
- name: test-packaged-app-ubuntu
display_name: Test Packaged App Ubuntu 20.04
run_on: ubuntu2004-large
patchable: true
Expand All @@ -156,7 +156,7 @@ buildvariants:
- name: test-packaged-app-1
- name: test-packaged-app-2
- name: test-packaged-app-3
- name: test-server-windows
- name: test-packaged-app-windows
display_name: Test Packaged App Windows 10
run_on: windows-vsCurrent-large
patchable: true
Expand All @@ -167,7 +167,7 @@ buildvariants:
- name: test-packaged-app-1
- name: test-packaged-app-2
- name: test-packaged-app-3
- name: test-server-rhel
- name: test-packaged-app-rhel
display_name: Test Packaged App RHEL 8.0
run_on: rhel80-large
patchable: true
Expand All @@ -178,7 +178,7 @@ buildvariants:
- name: test-packaged-app-1
- name: test-packaged-app-2
- name: test-packaged-app-3
- name: test-server-macos-11-arm
- name: test-packaged-app-macos-11-arm
display_name: Test Packaged App MacOS arm64 11
run_on: macos-1100-arm64-gui
patchable: true
Expand All @@ -189,7 +189,7 @@ buildvariants:
- name: test-packaged-app-1
- name: test-packaged-app-2
- name: test-packaged-app-3
- name: test-server-macos-11-x64
- name: test-packaged-app-macos-11-x64
display_name: Test Packaged App MacOS x64 11
run_on: macos-1100-gui
patchable: false
Expand All @@ -200,6 +200,28 @@ buildvariants:
- name: test-packaged-app-1
- name: test-packaged-app-2
- name: test-packaged-app-3
- name: test-packaged-app-macos-14-arm
display_name: Test Packaged App MacOS arm64 14
run_on: macos-14-arm64-gui
patchable: true
depends_on:
- name: package-compass
variant: package-macos-arm
tasks:
- name: test-packaged-app-1
- name: test-packaged-app-2
- name: test-packaged-app-3
- name: test-packaged-app-macos-14-x64
display_name: Test Packaged App MacOS x64 14
run_on: macos-14-gui
patchable: false
depends_on:
- name: package-compass
variant: package-macos-x64
tasks:
- name: test-packaged-app-1
- name: test-packaged-app-2
- name: test-packaged-app-3
- name: publish
display_name: Publish Artifacts
run_on: ubuntu2004-large
Expand Down
Loading