Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): build and test packaged app on the newer macos version (2nd attempt) COMPASS-8090 #6232

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

kraenhansen
Copy link
Contributor

@kraenhansen kraenhansen commented Sep 12, 2024

Description

Second attempt at #6220 (which had to be reverted in #6230). It was reverted because running the tests were not patchable and failed because the host was not logged into a graphical shell.

Here's a patch which sets patchable: true to convince yourself this works: https://spruce.mongodb.com/version/66fedc4f7d7d0700078cc466/tasks

A friendly takeover of #5990 incorporating @mcasimir's feedback: #5990 (comment)

Updates the build variants used for packaging the app on MacOS to 14 and adds two new test variants for the MacOS 14. We might want to simply remove test-packaged-app-macos-11-arm and test-packaged-app-macos-11-x64 in the future.

Note: To avoid this regression in the future, I experimented with added a task taking a screenshot as an early sanity check. While this worked on the Arm64 Mac 14s, this failed on the macos-1100 hosts (likely due to lack of permissions) although tests run perfectly fine.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen self-assigned this Sep 12, 2024
@kraenhansen kraenhansen force-pushed the kh/8090-use-new-macos-distros-2 branch from ac88599 to 6c5804b Compare September 20, 2024 07:29
@kraenhansen kraenhansen force-pushed the kh/8090-use-new-macos-distros-2 branch 8 times, most recently from 31946f1 to 649fc77 Compare September 30, 2024 19:31
@kraenhansen kraenhansen force-pushed the kh/8090-use-new-macos-distros-2 branch 3 times, most recently from 74b9917 to a2d4ed8 Compare October 2, 2024 11:10
@kraenhansen kraenhansen added the no release notes Fix or feature not for release notes label Oct 2, 2024
@kraenhansen kraenhansen force-pushed the kh/8090-use-new-macos-distros-2 branch from a2d4ed8 to 75ac50a Compare October 3, 2024 18:01
@kraenhansen kraenhansen marked this pull request as ready for review October 3, 2024 18:08
@kraenhansen kraenhansen requested review from lerouxb and removed request for mabaasit October 4, 2024 07:37
@lerouxb
Copy link
Contributor

lerouxb commented Oct 4, 2024

Well done! What a journey 😄

@kraenhansen kraenhansen merged commit 495c140 into main Oct 4, 2024
30 checks passed
@kraenhansen kraenhansen deleted the kh/8090-use-new-macos-distros-2 branch October 4, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants