Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loongarch64 support for archutil #4392

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

yzewei
Copy link
Contributor

@yzewei yzewei commented Oct 31, 2023

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.

@tonistiigi
Copy link
Member

I'm not sure if we want to include this in regular release as it does add overhead to detect these architectures that are rarely used. Maybe with a special go build tag?

@tonistiigi
Copy link
Member

@yzewei Comment from #4392 (review) has not been addressed.

@yzewei
Copy link
Contributor Author

yzewei commented Nov 14, 2023

@yzewei Comment from #4392 (review) has not been addressed.

Thank you for your suggestions and reminders. I have recently provided Loongarch adaptation for Buildkit, in order to complete the work of building mirrors cross -architecture on Loongarch
Based on your previous reply, I recently provided Loongarch support for the xx project
I do n’t understand what you said to add a special Go Build label. I use xx-go after the xx project is transplanted?

@tonistiigi
Copy link
Member

I recently provided Loongarch support for the xx project

I don't see any new PRs against xx

@yzewei
Copy link
Contributor Author

yzewei commented Nov 15, 2023

I recently provided Loongarch support for the xx project

I don't see any new PRs against xx

Sorry, I don't think I can express my meaning clearly. I am doing this. I expected to be submitted this week

@yzewei
Copy link
Contributor Author

yzewei commented Dec 5, 2023

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.

The PR has been submitted. Thank you for your support in building the ecosystem for the Loongarch architecture!
xx-PR

@yzewei yzewei force-pushed the add-loongarch-for-util branch 3 times, most recently from 1c50377 to 5f1872d Compare December 22, 2023 02:04
@yzewei
Copy link
Contributor Author

yzewei commented Dec 22, 2023

squash commits to 1

@yzewei yzewei force-pushed the add-loongarch-for-util branch 2 times, most recently from 55015d8 to 52108fd Compare December 22, 2023 03:04
@yzewei
Copy link
Contributor Author

yzewei commented Jan 9, 2024

PTAL

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit otherwise LGTM

util/archutil/Dockerfile Outdated Show resolved Hide resolved
@yzewei yzewei changed the title add loongarch support for archutil add loongarch64 support for archutil Jan 10, 2024
@yzewei
Copy link
Contributor Author

yzewei commented Jan 12, 2024

What other questions?

util/archutil/Dockerfile Outdated Show resolved Hide resolved
@yzewei yzewei requested a review from crazy-max January 12, 2024 09:30
@yzewei
Copy link
Contributor Author

yzewei commented Jan 15, 2024

Is there any problem with this PR?

Copy link

@dongjiang1989 dongjiang1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

util/archutil/Dockerfile Outdated Show resolved Hide resolved
util/archutil/Dockerfile Outdated Show resolved Hide resolved
@crazy-max
Copy link
Member

crazy-max commented Feb 9, 2024

@yzewei Needs rebase related to changes from #4607. This should kick ci and validate archutil.

EDIT: rebased myself and pushed changes.

@crazy-max
Copy link
Member

crazy-max commented Feb 12, 2024

@yzewei Seems aarch64 package does not exist from previous comment, see: https://github.com/moby/buildkit/actions/runs/7868985167/job/21467181513?pr=4392#step:5:252

#14 7.644 Fetched 9268 kB in 7s (1284 kB/s)
#14 7.644 Reading package lists...
#14 26.25 Reading package lists...
#14 44.69 Building dependency tree...
#14 49.04 Reading state information...
#14 49.10 E: Unable to locate package binutils-loongarch64-linux-gnu

You can try locally with docker buildx bake validate-archutil --set "*.platform=linux/arm64"

@yzewei
Copy link
Contributor Author

yzewei commented Feb 18, 2024

binutils-loongarch64-linux-gnu

Sorry, you are right. The debian image in the arm architecture does not have this toolkit. What else do I need to do?
As the debian community improves its support for the loongarch architecture, more architecture support should be added in the future, such as aarch64
Can we currently only verify the amd64 architecture and temporarily block the arm64 architecture?

@crazy-max crazy-max added this to the v0.13.0 milestone Mar 1, 2024
@crazy-max crazy-max merged commit b7d04a8 into moby:master Mar 1, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants