-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add loongarch64 support for archutil #4392
Conversation
I'm not sure if we want to include this in regular release as it does add overhead to detect these architectures that are rarely used. Maybe with a special go build tag? |
@yzewei Comment from #4392 (review) has not been addressed. |
Thank you for your suggestions and reminders. I have recently provided Loongarch adaptation for Buildkit, in order to complete the work of building mirrors cross -architecture on Loongarch |
I don't see any new PRs against xx |
Sorry, I don't think I can express my meaning clearly. I am doing this. I expected to be submitted this week |
The PR has been submitted. Thank you for your support in building the ecosystem for the Loongarch architecture! |
1c50377
to
5f1872d
Compare
squash commits to 1 |
55015d8
to
52108fd
Compare
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit otherwise LGTM
52108fd
to
387628e
Compare
What other questions? |
Is there any problem with this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
12eb4df
to
5ccecf5
Compare
Signed-off-by: yzewei <[email protected]>
5ccecf5
to
736c35a
Compare
@yzewei Seems aarch64 package does not exist from previous comment, see: https://github.com/moby/buildkit/actions/runs/7868985167/job/21467181513?pr=4392#step:5:252
You can try locally with |
Sorry, you are right. The debian image in the arm architecture does not have this toolkit. What else do I need to do? |
Signed-off-by: CrazyMax <[email protected]>
The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.