-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add loong64 support for src #130
Conversation
@tonistiigi @tiborvass Thanks! |
Don't forget to enable CI as well and add extra tests where needed (eg. in info at least). |
The latest commit adds test-related code |
src/xx-apt
Outdated
apt-get update | ||
apt-get install -y debian-ports-archive-keyring | ||
if [ -z "$XX_APT_REPO_URL_LOONGARCH64" ]; then | ||
echo "Please set the environment variable XX_APT_REPO_URL_LOONGARCH64=pkg.loongnix.cn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://ftp.ports.debian.org/debian-ports/pool-loong64/ does not work as a default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://ftp.ports.debian.org/debian-ports/pool-loong64/ does not work as a default?
At present, this link does not work. Can it be for the time being, and then correct it after actual use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the issue with the debian link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the issue with the debian link?
Since the ABI atmosphere ABI 1.0 and ABI2.0 under the ABI atmosphere under Loongarch, the current debian official source link supports ABI2.0. The source link in the current code is the ABI 1.0 software source maintained by Loongarch, ABI1.0 and ABI2.0 The distinction can be performed through Loongarch64 and Loong64. Thank you for your reminder!
src/xx-apt
Outdated
echo "Please set the environment variable XX_APT_REPO_URL_LOONGARCH64=pkg.loongnix.cn" | ||
exit 0; | ||
fi | ||
echo "deb [ arch=loongarch64 ] http://pkg.loongnix.cn/loongnix DaoXiangHu-stable main contrib non-free" >>/etc/apt/sources.list.d/loongarch64.list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use the env as well. You can put the distro in another env or combine them somehow.
src/xx-info
Outdated
@@ -337,6 +340,14 @@ case "$TARGETARCH" in | |||
XX_RHEL_ARCH="mips64el" | |||
XX_TRIPLE="mips64el${vendor}-linux-${XX_LIBC}abi64" | |||
;; | |||
"loongarch64") | |||
XX_MARCH="loongarch64" | |||
XX_DEBIAN_ARCH="loongarch64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like debian name is loong64
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same as the above problem, I will add
PTAL CI failures. Looks like at least an issue with the |
This comment was marked as abuse.
This comment was marked as abuse.
Signed-off-by: yzewei <[email protected]>
It seems that the test-clang.bats file's verification of ppc64le and armv8 has problems that cause the CI failure |
This comment was marked as abuse.
This comment was marked as abuse.
util/bats-assert/Dockerfile has a problem with the build image, and it has been corrected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bats issue covered by #134
@@ -127,7 +127,8 @@ target "_all-platforms" { | |||
"linux/mips64le", | |||
"linux/ppc64le", | |||
"linux/s390x", | |||
"linux/riscv64" | |||
"linux/riscv64", | |||
"linux/loong64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace issue here and other places in HCL
be84379
to
2008cc9
Compare
Signed-off-by: yzewei <[email protected]>
@tonistiigi @crazy-max The PR of add loong64 support has been moved 139 |
I'm sorry to complete this PR so late. I am busy some time ago. I have only been free now. Thank you very much for your attention!
Let me give you the lowdown once again: Loongarch, also known as Loongarch, is a badass RISC-style Instruction Set Architecture (ISA). It's all the rage in the open-source community and has been rocking long-term support.